From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Liam Girdwood <lrg-l0cyMroinI0@public.gmane.org>,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] ASoC: Tegra: Implement SPDIF CPU DAI
Date: Sat, 2 Jul 2011 12:16:07 -0700 [thread overview]
Message-ID: <20110702191607.GA10505@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1309550175-30551-4-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On Fri, Jul 01, 2011 at 01:56:15PM -0600, Stephen Warren wrote:
> +struct snd_soc_dai_driver tegra_spdif_dai = {
> + .name = DRV_NAME ".0",
This looks wrong - what's with the .0? If there can be only one device
there should be no number, if there can be multiple devices hard coding
is bad karma. Either way the number should come from the instantiation.
next prev parent reply other threads:[~2011-07-02 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 19:56 [PATCH 0/3] ASoC: Tegra: Fixes and SPDIF support Stephen Warren
[not found] ` <1309550175-30551-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-07-01 19:56 ` [PATCH 1/3] ASoC: Tegra: I2S: Ensure clock is enabled when writing regs Stephen Warren
2011-07-01 19:56 ` [PATCH 2/3] ASoC: Tegra: I2S: s/clk_get_sys/clk_get/ Stephen Warren
2011-07-01 19:56 ` [PATCH 3/3] ASoC: Tegra: Implement SPDIF CPU DAI Stephen Warren
[not found] ` <1309550175-30551-4-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-07-02 19:16 ` Mark Brown [this message]
2011-07-04 10:10 ` Liam Girdwood
2011-07-04 15:50 ` [PATCH 0/3] ASoC: Tegra: Fixes and SPDIF support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110702191607.GA10505@opensource.wolfsonmicro.com \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lrg-l0cyMroinI0@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox