nvec TODO

nvec TODO

[Russell King - ARM Linux]

Greg,

A small patch to add something to this staging drivers todo list which
I just noticed.  BTW, why isn't there any easy way to find a list of
addresses to copy against stuff in staging?  I hope I have everyone...

The note is about something which should be easy enough to fix by people
who know the Tegra stuff (it probably involves changes outside of this
driver to fix.)

8<-------
From: Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Staging: Add clk API note to nvec/TODO

Add a note about the abuse of the clk API to the nvec/TODO list.

Signed-off-by: Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
--- 
 drivers/staging/nvec/TODO |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/nvec/TODO b/drivers/staging/nvec/TODO
index 77b47f7..649d6b7 100644
--- a/drivers/staging/nvec/TODO
+++ b/drivers/staging/nvec/TODO
@@ -4,5 +4,7 @@ ToDo list (incomplete, unordered)
 	- add compile as module support
 	- move nvec devices to mfd cells?
 	- adjust to kernel style
-
-
+	- fix clk usage
+	  should not be using clk_get_sys(), but clk_get(&pdev->dev, conn)
+	  where conn is either NULL if the device only has one clock, or
+	  the device specific name if it has multiple clocks.

Re: nvec TODO

[Marc Dietich]

Hi Russell, Greg,

> Greg,
> 
> A small patch to add something to this staging drivers todo list which
> I just noticed.  BTW, why isn't there any easy way to find a list of
> addresses to copy against stuff in staging?  I hope I have everyone...

the Tegra/Nvidia/Google people are not involved in this driver development. The 
hw was used in the first generation Android devices only and became kind of 
obsolete (in kernels > .32 released by NV), but still there are a handfull older 
devices using it. That's why some community people (ml: 
ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt@public.gmane.org, irc:#ac100 on freenode) try to port it to newer 
kernels. 

> The note is about something which should be easy enough to fix by people
> who know the Tegra stuff (it probably involves changes outside of this
> driver to fix.)

I'll post some update to the driver soon (V2 of the patches I already submitted, 
http://driverdev.linuxdriverproject.org/pipermail/devel/2011-July/018751.html). 
In fact, the clock stuff should be done by the i2c-tegra driver and not in nvec 
itself. I hope I have time to prepare a corresponding patch for the next merge 
window (kernel 3.2). So the patch below is not needed anymore. 

Thanks

Marc


> 8<-------
> From: Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
> Staging: Add clk API note to nvec/TODO
> 
> Add a note about the abuse of the clk API to the nvec/TODO list.
> 
> Signed-off-by: Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
> ---
>  drivers/staging/nvec/TODO |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/nvec/TODO b/drivers/staging/nvec/TODO
> index 77b47f7..649d6b7 100644
> --- a/drivers/staging/nvec/TODO
> +++ b/drivers/staging/nvec/TODO
> @@ -4,5 +4,7 @@ ToDo list (incomplete, unordered)
>  	- add compile as module support
>  	- move nvec devices to mfd cells?
>  	- adjust to kernel style
> -
> -
> +	- fix clk usage
> +	  should not be using clk_get_sys(), but clk_get(&pdev->dev, conn)
> +	  where conn is either NULL if the device only has one clock, or
> +	  the device specific name if it has multiple clocks.

Re: nvec TODO

[Russell King - ARM Linux]

On Mon, Aug 01, 2011 at 01:28:28PM +0200, Marc Dietich wrote:
> Hi Russell, Greg,
> 
> > Greg,
> > 
> > A small patch to add something to this staging drivers todo list which
> > I just noticed.  BTW, why isn't there any easy way to find a list of
> > addresses to copy against stuff in staging?  I hope I have everyone...
> 
> the Tegra/Nvidia/Google people are not involved in this driver development. The 
> hw was used in the first generation Android devices only and became kind of 
> obsolete (in kernels > .32 released by NV), but still there are a handfull older 
> devices using it. That's why some community people (ml: 
> ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt@public.gmane.org, irc:#ac100 on freenode) try to port it to newer 
> kernels. 

That reinforces my point - there's no way to know who should be copied
with mails for stuff in staging.

> > The note is about something which should be easy enough to fix by people
> > who know the Tegra stuff (it probably involves changes outside of this
> > driver to fix.)
> 
> I'll post some update to the driver soon (V2 of the patches I already submitted, 
> http://driverdev.linuxdriverproject.org/pipermail/devel/2011-July/018751.html). 
> In fact, the clock stuff should be done by the i2c-tegra driver and not in nvec 
> itself. I hope I have time to prepare a corresponding patch for the next merge 
> window (kernel 3.2). So the patch below is not needed anymore. 

Good news.

Thanks.

Re: nvec TODO

[Russell King - ARM Linux]

On Mon, Aug 01, 2011 at 01:28:28PM +0200, Marc Dietich wrote:
> Hi Russell, Greg,
> 
> > Greg,
> > 
> > A small patch to add something to this staging drivers todo list which
> > I just noticed.  BTW, why isn't there any easy way to find a list of
> > addresses to copy against stuff in staging?  I hope I have everyone...
> 
> the Tegra/Nvidia/Google people are not involved in this driver development. The 
> hw was used in the first generation Android devices only and became kind of 
> obsolete (in kernels > .32 released by NV), but still there are a handfull older 
> devices using it. That's why some community people (ml: 
> ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt@public.gmane.org, irc:#ac100 on freenode) try to port it to newer 
> kernels. 

And...

  ac100-+ipbUBPD95tH4x6Dk/4f9A@public.gmane.org
    SMTP error from remote mail server after RCPT TO:<ac100-+ipbUBPD95tH4x6Dk/4f9A@public.gmane.org>:
    host mx.launchpad.net [91.189.90.7]: 550 Unrouteable address

so that list is dead.

Re: nvec TODO

[Marc Dietich]

> On Mon, Aug 01, 2011 at 01:28:28PM +0200, Marc Dietich wrote:
> > Hi Russell, Greg,
> > 
> > > Greg,
> > > 
> > > A small patch to add something to this staging drivers todo list which
> > > I just noticed.  BTW, why isn't there any easy way to find a list of
> > > addresses to copy against stuff in staging?  I hope I have everyone...
> > 
> > the Tegra/Nvidia/Google people are not involved in this driver
> > development. The hw was used in the first generation Android devices
> > only and became kind of obsolete (in kernels > .32 released by NV), but
> > still there are a handfull older devices using it. That's why some
> > community people (ml:
> > ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt@public.gmane.org, irc:#ac100 on freenode) try to port it to
> > newer kernels.
> 
> And...
> 
>   ac100-+ipbUBPD95tH4x6Dk/4f9A@public.gmane.org
>     SMTP error from remote mail server after RCPT TO:<ac100-+ipbUBPD95tH4x6Dk/4f9A@public.gmane.org>:
>     host mx.launchpad.net [91.189.90.7]: 550 Unrouteable address
> 
> so that list is dead.

It's not dead, it's just my brain which is. The correct address is 
ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt@public.gmane.org (and subscribers only, you know). Sorry for the 
inconvenience. I'll add this address to the readme. Also note that this address 
is given in the copyright notice in the lastest patches.

Marc

Re: nvec TODO

[Greg KH]

On Mon, Aug 01, 2011 at 11:45:49AM +0100, Russell King - ARM Linux wrote:
> Greg,
> 
> A small patch to add something to this staging drivers todo list which
> I just noticed.  BTW, why isn't there any easy way to find a list of
> addresses to copy against stuff in staging?  I hope I have everyone...

We have MAINTAINERS entries for almost all staging drivers and of
course, scripts/get_maintainer.pl should show you everyone involved.

thanks,

greg k-h

Re: nvec TODO

[Russell King - ARM Linux]

On Mon, Aug 01, 2011 at 09:53:16AM -0700, Greg KH wrote:
> On Mon, Aug 01, 2011 at 11:45:49AM +0100, Russell King - ARM Linux wrote:
> > Greg,
> > 
> > A small patch to add something to this staging drivers todo list which
> > I just noticed.  BTW, why isn't there any easy way to find a list of
> > addresses to copy against stuff in staging?  I hope I have everyone...
> 
> We have MAINTAINERS entries for almost all staging drivers and of
> course, scripts/get_maintainer.pl should show you everyone involved.

Not in this case.

Re: nvec TODO

[Greg KH]

On Mon, Aug 01, 2011 at 06:06:16PM +0100, Russell King - ARM Linux wrote:
> On Mon, Aug 01, 2011 at 09:53:16AM -0700, Greg KH wrote:
> > On Mon, Aug 01, 2011 at 11:45:49AM +0100, Russell King - ARM Linux wrote:
> > > Greg,
> > > 
> > > A small patch to add something to this staging drivers todo list which
> > > I just noticed.  BTW, why isn't there any easy way to find a list of
> > > addresses to copy against stuff in staging?  I hope I have everyone...
> > 
> > We have MAINTAINERS entries for almost all staging drivers and of
> > course, scripts/get_maintainer.pl should show you everyone involved.
> 
> Not in this case.

Ick, you are right.  Marc, please update the TODO file with the correct
information, as well as providing a MAINTAINERS entry.

thanks,

greg k-h