From: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
To: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
Cc: Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Subject: Re: fix compilation error for linux 3.2
Date: Wed, 12 Oct 2011 20:48:15 -0700 [thread overview]
Message-ID: <20111013034815.GA6047@quad.lixom.net> (raw)
In-Reply-To: <2109696.pnkA82QAhR@fb07-iapwap2>
On Tue, Oct 11, 2011 at 10:28:23AM +0200, Marc Dietrich wrote:
> Hi Olof,
>
> Am Montag, 10. Oktober 2011, 10:45:48 schrieb Olof Johansson:
> > I can't reproduce this problem. CONFIG_SPI doesn't seem to be on for
> > tegra_defconfig (I'll revisit the defconfig and turn on missing
> > options for 3.2), but even after I enable it (plus CONFIG_SPI_TEGRA),
> > I don't see any errors here. I tried static build as well as module.
> > Can you provide more detail to what you're seeing?
>
> ah, sorry, it is needed for linux-next (which also happens to have a 3.1-rc9
> version). You can easily check if include/linux/device.h has module.h included or not
> (if not, tegra-spi fails to compile). I updated the subject.
Ok, makes sense. I don't see any relevant direct changes to the driver; it
seems that some of the include files used to pull in module.h and no longer
does.
Grant Likely is SPI maintainer, so it should go to him. Based on the commit
message comments, please resend a new version (and cc linux-tegra please).
> > > Signed-off-by: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
Feel free to add:
Acked-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
-Olof
prev parent reply other threads:[~2011-10-13 3:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 9:17 fix another compilation error in 3.1-rc9 Marc Dietrich
2011-10-10 17:45 ` Olof Johansson
[not found] ` <CAOesGMgyYebNw1vphaKf8SPLBvtSvwPa0nCLxr81UJ-BtSRhzA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-10-11 8:28 ` fix compilation error for linux 3.2 Marc Dietrich
2011-10-13 3:48 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013034815.GA6047@quad.lixom.net \
--to=olof-nzht3qvonbneowh0uzbu5w@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marvin24-Mmb7MZpHnFY@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox