Re: [PATCH] arm/tegra: Add device-tree support for TrimSlice board

[Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

* Stephen Warren wrote:
> Marc Dietrich wrote at Monday, October 24, 2011 3:28 PM:
> > On Monday 24 October 2011 12:01:07 Stephen Warren wrote:
> > > * Add device-tree file for TrimSlice
> > > * Add that to the list of .dts files to build
> > > * Update board-dt.c to recognize TrimSlice board name
> > >
> > > Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> > > ---
> > >  arch/arm/boot/dts/tegra-trimslice.dts |   38
> > > +++++++++++++++++++++++++++++++++ arch/arm/mach-tegra/Makefile.boot     |
> > >  1 +
> > >  arch/arm/mach-tegra/board-dt.c        |    3 ++
> > >  3 files changed, 42 insertions(+), 0 deletions(-)
> > >  create mode 100644 arch/arm/boot/dts/tegra-trimslice.dts
> > 
> > doesn't this also require to add something like
> > 
> > obj-${CONFIG_MACH_TEGRA_DT} += board-trimslice-pinmux.o
> > 
> > to the Makefile?
> 
> Yes, definitely. I've fixed this up locally; I hope to repost soon.

Can it please be obj-$(CONFIG_MACH_TEGRA_DT) instead? I think both Russell
and Olof agreed[0] to use parens instead of braces, even though the current
practice is to copy what previous boards did.

Thierry

[0]: http://article.gmane.org/gmane.linux.ports.tegra/1670

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]