From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 09/17] ASoC: Tegra I2S: Remove dependency on pdev->id Date: Wed, 23 Nov 2011 11:03:38 +0000 Message-ID: <20111123110338.GC21073@opensource.wolfsonmicro.com> References: <1322011285-4002-1-git-send-email-swarren@nvidia.com> <1322011285-4002-10-git-send-email-swarren@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1322011285-4002-10-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Liam Girdwood , Olof Johansson , Colin Cross , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Mike Rapoport , John Bonesio , Grant Likely , Marc Dietrich , Leon Romanovsky , Peter De Schrijver , Rob Herring , Ian Lartey , Dimitris Papastamos List-Id: linux-tegra@vger.kernel.org On Tue, Nov 22, 2011 at 06:21:17PM -0700, Stephen Warren wrote: > + i2s->dai = tegra_i2s_dai_template; > + i2s->dai.name = pdev->name; > + This should really be part of the same commit as the arch/arm side change in order to avoid bisection breaks as from the point of view of non-DT systems it's moving the number into the name.