From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] arm/tegra: boards: more __init/__initdata annotations Date: Tue, 20 Dec 2011 09:23:52 +0100 Message-ID: <20111220082352.GW24496@pengutronix.de> References: <1324353802-31774-1-git-send-email-olof@lixom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1324353802-31774-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Olof Johansson Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Mon, Dec 19, 2011 at 08:03:22PM -0800, Olof Johansson wrote: > Silence a bunch of section warnings, and mark some of the init functi= ons as > __init. >=20 > Signed-off-by: Olof Johansson > --- > arch/arm/mach-tegra/board-harmony-pinmux.c | 8 ++++---- > arch/arm/mach-tegra/board-paz00-pinmux.c | 8 ++++---- > arch/arm/mach-tegra/board-seaboard-pinmux.c | 16 ++++++++-------- > arch/arm/mach-tegra/board-trimslice-pinmux.c | 4 ++-- > 4 files changed, 18 insertions(+), 18 deletions(-) >=20 > diff --git a/arch/arm/mach-tegra/board-harmony-pinmux.c b/arch/arm/ma= ch-tegra/board-harmony-pinmux.c > index 465808c..84cfbef 100644 > --- a/arch/arm/mach-tegra/board-harmony-pinmux.c > +++ b/arch/arm/mach-tegra/board-harmony-pinmux.c > @@ -25,7 +25,7 @@ > #include "board-harmony.h" > #include "board-pinmux.h" > =20 > -static struct tegra_pingroup_config harmony_pinmux[] =3D { > +static __initdata struct tegra_pingroup_config harmony_pinmux[] =3D = { The correct syntax is: static struct tegra_pingroup_config harmony_pinmux[] __initdata =3D { that is, __initdata has to be at the end. I havn't looked, but it might be possible to mark these as const, too (and then use __initconst instead of __initdata). Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= |