From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH V2] regulator: tps65910: Sleep control through external inputs Date: Wed, 25 Jan 2012 12:50:20 +0000 Message-ID: <20120125125020.GI3687@opensource.wolfsonmicro.com> References: <1327489068-9460-1-git-send-email-ldewangan@nvidia.com> <20120125124250.GH3687@opensource.wolfsonmicro.com> <4F1FF9EF.9000004@nvidia.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AptwxgnoZDC4KQWS" Return-path: Content-Disposition: inline In-Reply-To: <4F1FF9EF.9000004-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan Cc: "lrg-l0cyMroinI0@public.gmane.org" , "jedu-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org" , "sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" , "gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org --AptwxgnoZDC4KQWS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 25, 2012 at 06:17:43PM +0530, Laxman Dewangan wrote: > On Wednesday 25 January 2012 06:12 PM, Mark Brown wrote: > >This really isn't what the set_mode() API is for - especially the fact > >that it supports turning the regulator off which really isn't what > >set_mode() is supposed to do. A generic driver using this API isn't > >going to play too well. > Then what should be the method? Is it through the macro similar to > patch V1 where LOW_POWER mode option come from platform data? The > idea is to set the regulator in OFF or low power mode based on > external control. Like I said we've got the various suspend callbacks for setting the behaviour in suspend mode. --AptwxgnoZDC4KQWS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPH/pwAAoJEBus8iNuMP3dIewQAILgQll5a7NUoiobDIiXvWFy mL7YPabxYtTgclVOkeFLE298KvUgZtOa7l15aeovOcUkUlP9fh1Lw/fb3D/P8w/X OMcxkMFb36w4gB6ebnYSSCF82tlD557OoBXFotqtk+4N/eTV/YyvYnGoesC732NB PmuZM0mNUfNH2+b+H/hr7+0DeiN9MnXHRbuCYIJ4zwPUL1rFhF42ziUXlgXXC5kX 842hGYs1xkCdAqscwSXcEfM6fWqBkCmEoGSGOXjc9tFuh7mP/0bRmV3pphHvajKX wxYxr6JX3gnCaM0BuUJLXlQgb2sKv6OsSVMZA+QUURxda8qYVoTXKJB/gDoXH48D Y4IdxUMxQqHB+XqCwrIWVVAP4PAOsQ6Chd99amK4jNUxZVs67UwF835SqPJdjv0g nS+ABwWKdx4rxmXvbEWWXCpP16RAzQxQh4AiW/37zzCt/fOdziLWGSQEub/ybc1u frXfDLkst+Yi3gXQJgc0fJlN8acMZZA/bVmQsKdzCssTQMVx9sm5eLS+hAmDNtYZ 6xMcaeY8me6nKfO1y5mQTX4ttwpdZ3DxI13pFBYRGn1RLrpR3ikh3BaoBtO3Tq7i Is8E3X/FRcUZDgAXDa2Fqt0YSDtbdAuCYuOgz+4ZQFjVweXd/pwqeFcO9nmo7bII GwNwC2R9QZn7WDlLSVlA =zBv4 -----END PGP SIGNATURE----- --AptwxgnoZDC4KQWS--