From: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
To: Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: tegra: PCIe: Provide 3.3V supply voltage
Date: Fri, 17 Feb 2012 20:16:05 +0100 [thread overview]
Message-ID: <20120217191605.GA11127@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <20120217163931.GB961-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
* Mark Brown wrote:
> On Fri, Feb 17, 2012 at 04:44:28PM +0100, Thierry Reding wrote:
>
> > + err = regulator_set_voltage(regulator, 3300000, 3300000);
> > + if (err < 0)
> > + goto err_put;
> > +
>
> This is a bit weird, why is this not just set by constraints?
I guess because I didn't know any better. I don't have access to the hardware
right now, so it'll have to wait until Monday. I'll follow up with a patch
after I've verified that setting via constraints works.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-02-17 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 15:44 [PATCH] ARM: tegra: PCIe: Provide 3.3V supply voltage Thierry Reding
[not found] ` <1329493468-7741-1-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2012-02-17 16:39 ` Mark Brown
[not found] ` <20120217163931.GB961-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-02-17 19:16 ` Thierry Reding [this message]
[not found] ` <20120217191605.GA11127-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2012-02-17 19:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217191605.GA11127@avionic-0098.adnet.avionic-design.de \
--to=thierry.reding-rm9k5ik7kjkj5m59nbduvrnah6klmebb@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).