From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 8/8] ARM: tegra: HACK: remove set_irq_flags() from driver Date: Thu, 1 Mar 2012 11:36:43 -0800 Message-ID: <20120301193643.GA607@kroah.com> References: <1330630010-11241-1-git-send-email-alan@signal11.us> <1330630010-11241-9-git-send-email-alan@signal11.us> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1330630010-11241-9-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alan Ott Cc: Russell King , Colin Cross , Olof Johansson , Stephen Warren , Grant Likely , Linus Walleij , Alan Stern , Lucas De Marchi , Arnd Bergmann , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Thu, Mar 01, 2012 at 02:26:50PM -0500, Alan Ott wrote: > From: Arnd Bergmann > > The driver should not call set_irq_flags itself, and > cannot do this from a loadable module. > > Remove the call for now, which might break the driver > but at least lets the kernel link again. > > Signed-off-by: Arnd Bergmann Um, I think you should test this out before submitting it anywhere :) As it is, I can't accept it. greg k-h