From: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
To: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: dt: Explicitly configure all serial ports on Tegra Cardhu
Date: Sun, 4 Mar 2012 10:47:53 -0800 [thread overview]
Message-ID: <20120304184753.GA32119@quad.lixom.net> (raw)
In-Reply-To: <1328210659-16869-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On Thu, Feb 02, 2012 at 12:24:19PM -0700, Stephen Warren wrote:
> The ports are used as follows:
> UART1/A: Routed to debug dongle
> UART2/B: GPS
> UART3/C: Bluetooth
> UART4/D: Routed to debug dongle
> UART5/E: Not connected
>
> The debug dongle has jumpers to connect either UART1/A or UART4/D to
> the DB-9 connector. UART1/A is typically used on Cardhu, and is the option
> we assume here.
>
> For now, only enable UART1/A, and explicitly disable all other ports.
>
> The explicit disable prevents the message "of_serial 70006040.serial:
> no clock-frequency property set" being printed during boot.
>
> Enabling the other ports requires their clocks to be enabled, or accesses
> to the registers will hang. At present, this requires adding entries into
> board-dt-tegra30.c's tegra_dt_clk_init_table[]. Lets punt on that and wait
> for the common clock bindings to set this all up, although that will also
> requiring adding clock support to 8250.c.
>
> While we're at it, fix board-dt-tegra30.c to enable the correct clock for
> the debug UART. We got away with this before, because the bootloader already
> enabled it.
>
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Thanks, applied to for-3.4/t30-smp (since it depends on other changes there).
-Olof
prev parent reply other threads:[~2012-03-04 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 19:24 [PATCH] ARM: dt: Explicitly configure all serial ports on Tegra Cardhu Stephen Warren
[not found] ` <1328210659-16869-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-03-04 18:47 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120304184753.GA32119@quad.lixom.net \
--to=olof-nzht3qvonbneowh0uzbu5w@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox