From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 11/11] ARM: tegra: pcie: Add device tree support Date: Fri, 9 Mar 2012 07:31:16 +0100 Message-ID: <20120309063115.GA25208@avionic-0098.mockup.avionic-design.de> References: <1331218291-16119-1-git-send-email-thierry.reding@avionic-design.de> <1331218291-16119-12-git-send-email-thierry.reding@avionic-design.de> <4F59253D.7070100@wwwdotorg.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9067474724657529063==" Return-path: In-Reply-To: <4F59253D.7070100-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Stephen Warren Cc: Russell King , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Mark Brown , Jesse Barnes , Rob Herring , Colin Cross , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Liam Girdwood , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-tegra@vger.kernel.org --===============9067474724657529063== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gBBFr7Ir9EOA20Yy" Content-Disposition: inline --gBBFr7Ir9EOA20Yy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Stephen Warren wrote: > On 03/08/2012 07:51 AM, Thierry Reding wrote: > > This commit adds support for instantiating the Tegra PCIe controller > > from a device tree. > >=20 > > Signed-off-by: Thierry Reding >=20 > > diff --git a/Documentation/devicetree/bindings/pci/tegra-pcie.txt b/Doc= umentation/devicetree/bindings/pci/tegra-pcie.txt >=20 > > +NVIDIA Tegra PCIe controller > > + > > +Required properties: > > +- compatible: "nvidia,tegra20-pcie" > > +- reg: physical base address and length of the controller's registers > > +- interrupts: the interrupt outputs of the controller > > + > > +Optional properties: > > +- pex-clk-supply: supply voltage for internal reference clock > > +- vdd-supply: power supply for controller (1.05V) >=20 > Mark, Liam, >=20 > Should those *-supply properties really be optional? I got the > impression talking to Mark in a different thread that all regulators > should exist, although their implementation may be via a fixed > regulator, with no GPIO, as determined by the board design. If I read the TrimSlice code correctly, there is no regulator setup required to make PCIe work there presumably because they hardwire the proper voltage= s. On the other hand, maybe a better solution in this case would be to use the dummy regulator in those cases. Thierry --gBBFr7Ir9EOA20Yy Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAk9Zo7MACgkQZ+BJyKLjJp+/iwCgiDXU0dcQ1FjrN2HsjdQOr5t/ 9GEAn0zL3ekkbOzXL9+9lWi7StLwDECy =000z -----END PGP SIGNATURE----- --gBBFr7Ir9EOA20Yy-- --===============9067474724657529063== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss --===============9067474724657529063==--