From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v4 03/10] pwm: Add device tree support Date: Thu, 15 Mar 2012 12:44:37 +0000 Message-ID: <201203151244.37483.arnd@arndb.de> References: <1331740593-10807-1-git-send-email-thierry.reding@avionic-design.de> <201203150840.42659.arnd@arndb.de> <20120315102944.GB3138@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120315102944.GB3138-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Thierry Reding , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Mitch Bradley , Mike Frysinger , Ryan Mallon , Stephen Warren , Sascha Hauer , Colin Cross , Rob Herring , Grant Likely , Olof Johansson , Lars-Peter Clausen , Richard Purdie , Matthias Kaehlcke , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Eric Miao , Kurt Van Dijck List-Id: linux-tegra@vger.kernel.org On Thursday 15 March 2012, Mark Brown wrote: > Similar code is going in for regulators in 3.4 along with the core > -EPROBE_DEFER change (though not OF specific) and I sent a similar patch > for GPIOs too, hopefully Grant will ack it in time for it to make it in. > > My theory is that since you need to explicitly know that the thing > you're requesting is there in order to request it (eg, have a PWM number > or DT link) the overwhemlingly common case for a failure to request will > be that the provider didn't register yet which is exactly the case where > deferral is desired. It therefore seems sensible to have the framework > default the drivers to retrying rather than have almost every individual > driver look at the failure, figure out if it was a missing provider, and > then retry. Drivers that have a good reason to fail can always check > for -EPROBE_DEFER and override it. > > The result should be that we can take advantage of probe deferral over > large areas of the kernel without having to go and explicitly modify so > many drivers - if the frameworks like GPIO, clk and regulator can do > this that ought to cover 90% of the cases where probe deferral will be > needed without having to do anything more than have good error handling > paths on probe which is a good idea anyway. Ok, makes sense. Thanks, Arnd