From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v4 05/10] ARM: tegra: Provide clock for only one PWM controller Date: Tue, 20 Mar 2012 09:44:03 +0100 Message-ID: <20120320084403.GB20249@avionic-0098.adnet.avionic-design.de> References: <1331740593-10807-1-git-send-email-thierry.reding@avionic-design.de> <1331740593-10807-6-git-send-email-thierry.reding@avionic-design.de> <4F67E8E4.7000604@wwwdotorg.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1LKvkjL3sHcu1TtY" Return-path: Content-Disposition: inline In-Reply-To: <4F67E8E4.7000604-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sascha Hauer , Arnd Bergmann , Matthias Kaehlcke , Kurt Van Dijck , Rob Herring , Grant Likely , Colin Cross , Olof Johansson , Richard Purdie , Mark Brown , Mitch Bradley , Mike Frysinger , Eric Miao , Lars-Peter Clausen , Ryan Mallon List-Id: linux-tegra@vger.kernel.org --1LKvkjL3sHcu1TtY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Stephen Warren wrote: > On 03/14/2012 09:56 AM, Thierry Reding wrote: > > A subsequent patch will add a generic PWM API driver for the Tegra PWFM > > controller, supporting all four PWM devices with a single PWM chip. The > > device will be named tegra-pwm and only one clock needs to be provided. > >=20 > > Signed-off-by: Thierry Reding > > Acked-by: Stephen Warren > ... > > - CLK_DUPLICATE("pwm", "tegra_pwm.0", NULL), > > - CLK_DUPLICATE("pwm", "tegra_pwm.1", NULL), > > - CLK_DUPLICATE("pwm", "tegra_pwm.2", NULL), > > - CLK_DUPLICATE("pwm", "tegra_pwm.3", NULL), > > + CLK_DUPLICATE("pwm", "tegra-pwm", NULL), >=20 > I thought harder about this: Why not delete /all/ the CLK_DUPLICATE()s > for PWM, and change the second parameter to PERIPH_CLK for PWM from > "pwm" to "tegra-pwm"? I think that should work. I'll retest and will update the patch accordingly. I assume that you're Acked-by will remain valid after those changes? Thierry --1LKvkjL3sHcu1TtY Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAk9oQ1MACgkQZ+BJyKLjJp8mjACfRWgwA5Rlf82tSVQDPxsqbcV5 X1wAnj7me9DbZqWQaJvn7vJI+57EaCwJ =qo1S -----END PGP SIGNATURE----- --1LKvkjL3sHcu1TtY--