From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH 06/11] ARM: tegra: seaboard: Don't gpio_request() ISL29018_IRQ Date: Wed, 4 Apr 2012 10:59:33 -0700 Message-ID: <20120404175933.GF29919@quad.lixom.net> References: <1333148404-17691-1-git-send-email-swarren@wwwdotorg.org> <1333148404-17691-7-git-send-email-swarren@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1333148404-17691-7-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Colin Cross , Linus Walleij , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Stephen Warren List-Id: linux-tegra@vger.kernel.org On Fri, Mar 30, 2012 at 04:59:59PM -0600, Stephen Warren wrote: > From: Stephen Warren > > Don't call gpio_request() or gpio_direction_input() for ISL29018_IRQ. > This pin is only used as an IRQ, and hence no GPIO configuration should > be necessary; the GPIO/IRQ driver should (and does) perform any required > setup when the IRQ is requested. > > Signed-off-by: Stephen Warren Acked-by: Olof Johansson