Re: [PATCH 2/2] iommu/tegra: gart: Reserve iomem resource

[Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]

* Hiroshi DOYU wrote:
> GART Register/Aperture range should be reserved.
> 
> Signed-off-by: Hiroshi DOYU <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/iommu/tegra-gart.c |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c
> index 33a23b6..a431006 100644
> --- a/drivers/iommu/tegra-gart.c
> +++ b/drivers/iommu/tegra-gart.c
> @@ -366,12 +366,18 @@ static int tegra_gart_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  	}
>  
> -	gart_regs = devm_ioremap(dev, res->start, resource_size(res));
> +	gart_regs = devm_request_and_ioremap(dev, res);
>  	if (!gart_regs) {
>  		dev_err(dev, "failed to remap GART registers\n");
>  		return -ENXIO;
>  	}
>  
> +	if (!devm_request_mem_region(dev, res_remap->start,
> +				     resource_size(res_remap), dev_name(dev))) {
> +		dev_err(dev, "failed to reserve GART aperture\n");
> +		return -EBUSY;
> +	}
> +

I'm not so sure that this is a good idea. If the GART driver requests the
GART aperture, then users of the GART aperture (e.g. the DRM driver) will no
longer be able to use it.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]