linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
	"olof@lixom.net" <olof@lixom.net>,
	Stephen Warren <swarren@nvidia.com>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 2/2] ARM: dt: tegra: cardhu: register core regulator tps65911
Date: Tue, 12 Jun 2012 00:20:41 +0800	[thread overview]
Message-ID: <20120611162040.GB4194@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FD6151E.8010405@wwwdotorg.org>

[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]

On Mon, Jun 11, 2012 at 09:56:14AM -0600, Stephen Warren wrote:

> * Each regulator-id/regulator-compatible value identifies a specific
> individual regulator within the chip that contains it. There is only one
> of each named regulator, since that's what exists in HW. So, this is
> about configuring HW that we know exists (because it's part of the HW
> represented by the parent node for the chip) rather than defining which
> HW is present on unprobeable busses, as the device-level compatible does.

> Given those differences, I really think that using "compatible" in the
> name of the property is just going to cause confusion.

This doesn't seem terribly different to me especially in some of the
cases people want to use this for where we try to describe the
subfunctions of the chip using this mechanism.  You have a fixed set of
regulators that might exist in a superset device (possibly with some
incompatibilities, or with additional properties providing more data on
the hardware) and then you mix and match what's in the system based
on the nodes you register for the subset device you're using.  This sort
of thing is actually much more idiomatic with DT than it is with
platform data (look at how people want to put device nodes in for the
MFD subfunctions all the time...).

Really all compatible is saying to me is "here's how you understand
this, handle it like an X" and this feels exactly the same.

Of course, if someone could just fix the DT to actually be able to do
key/value pairs, or allow us to do something useful with the
"regulator" string we need to put in there...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2012-06-11 16:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22 13:05 [PATCH 1/2] ARM: tegra: config: enable TPS65910 drivers Laxman Dewangan
2012-05-22 13:05 ` [PATCH 2/2] ARM: dt: tegra: cardhu: register core regulator tps65911 Laxman Dewangan
     [not found]   ` <1337691917-15040-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-22 16:40     ` Stephen Warren
     [not found]       ` <4FBBC192.7030900-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-05-22 17:09         ` Laxman Dewangan
     [not found]           ` <4FBBC830.2060802-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-22 17:19             ` Stephen Warren
     [not found]               ` <4FBBCA8F.3050903-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-05-22 17:56                 ` Laxman Dewangan
     [not found]                   ` <4FBBD33C.8020802-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-22 18:27                     ` Stephen Warren
     [not found]                       ` <4FBBDA97.6000006-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-05-22 18:42                         ` Laxman Dewangan
     [not found]                           ` <4FBBDE06.5080806-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-06-01 19:23                             ` Stephen Warren
     [not found]                               ` <4FC916AC.4060804-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-06-01 20:40                                 ` Mark Brown
     [not found]                                   ` <20120601204052.GB4258-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-06-01 20:44                                     ` Stephen Warren
     [not found]                                       ` <4FC92990.5030104-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-06-01 21:04                                         ` Mark Brown
     [not found]                                           ` <20120601210451.GC4258-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-06-02 21:19                                             ` Olof Johansson
     [not found]                                               ` <CAOesGMgYAR938F8PnVWaymzMBQwDKeAiUgEP81bv2nN14NmLGg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-03  2:45                                                 ` Rob Herring
     [not found]                                                   ` <4FCACFB6.2060601-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-06-03 12:05                                                     ` Mark Brown
     [not found]                                                       ` <20120603120506.GG4258-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-06-03 16:11                                                         ` Mitch Bradley
     [not found]                                                           ` <4FCB8CA9.40602-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>
2012-06-03 18:37                                                             ` Mark Brown
2012-06-03 11:55                                                 ` Mark Brown
2012-06-08 19:22                                 ` Laxman Dewangan
2012-06-09  3:06                                   ` Mark Brown
     [not found]                                     ` <20120609030608.GF3924-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-06-09  4:24                                       ` Stephen Warren
     [not found]                                         ` <4FD2CFE6.9070500-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-06-11  2:57                                           ` Mark Brown
     [not found]                                             ` <20120611025717.GE28211-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-06-11 15:56                                               ` Stephen Warren
2012-06-11 16:20                                                 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120611162040.GB4194@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=olof@lixom.net \
    --cc=swarren@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).