From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: Kconfig DRM_USB/DRM_UDL, and select vs. depends, and causing Tegra USB to be disabled Date: Tue, 4 Sep 2012 13:00:25 -0700 Message-ID: <20120904200025.GA18336@roeck-us.net> References: <50465430.3090806@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <50465430.3090806-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Sachin Kamat , Dave Airlie , Greg Kroah-Hartman , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , USB list , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Tue, Sep 04, 2012 at 01:19:12PM -0600, Stephen Warren wrote: > With respect to the following commits: > > df0b344 drm/usb: select USB_SUPPORT in Kconfig > 8f057d7 gpu/mfd/usb: Fix USB randconfig problems > > ... which end up with the following in next-20120904: > > config DRM_USB > depends on DRM > depends on USB_ARCH_HAS_HCD > select USB > select USB_SUPPORT > > config DRM_UDL > depends on DRM && EXPERIMENTAL > depends on USB_ARCH_HAS_HCD > select DRM_USB > > Surely this is backwards; these should be dependencies, not selects? In > other words: > > config DRM_USB > depends on DRM && USB > > config DRM_UDL > depends on DRM && EXPERIMENTAL && USB > select DRM_USB > > or perhaps: > > config DRM_USB > depends on DRM && USB > > config DRM_UDL > depends on DRM && EXPERIMENTAL && DRM_USB > > The problem here is that currently, the dependency logic for USB: > > config USB > depends on USB_ARCH_HAS_HCD > > ... is duplicated into each of DRM_USB and DRM_UDL, thus requiring both > of those to be edited should the dependencies for USB ever change. > This should be fixed with in https://patchwork.kernel.org/patch/1373371/ (drm: udl: usb: Fix recursive Kconfig dependency), which should make it into the next iteration of linux-next. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html