From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 1/2] ARM: config: sort select statements alphanumerically Date: Fri, 12 Oct 2012 08:09:47 -0700 Message-ID: <20121012150945.GB30339@atomide.com> References: <20121012132553.GK28061@n2100.arm.linux.org.uk> <20121012144119.GM28061@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20121012144119.GM28061@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Russell King - ARM Linux Cc: linux-sh@vger.kernel.org, Linus Walleij , Nicolas Ferre , Daniel Walker , Kevin Hilman , linux-samsung-soc@vger.kernel.org, Srinidhi Kasagar , Magnus Damm , David Brown , Jean-Christophe Plagniol-Villard , Alessandro Rubini , Stephen Warren , linux-arm-msm@vger.kernel.org, spear-devel@list.st.com, Sekhar Nori , Shiraz Hashim , Kukjin Kim , Haojian Zhuang , Ben Dooks , Barry Song , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Andrew Victor , linux-arm-kernel@lists.infradead.org, davinci-li List-Id: linux-tegra@vger.kernel.org * Russell King - ARM Linux [121012 07:44]: > On Fri, Oct 12, 2012 at 04:04:28PM +0200, Linus Walleij wrote: > > On Fri, Oct 12, 2012 at 3:26 PM, Russell King > > wrote: > > > > > As suggested by Andrew Morton: > > > > > > This is a pet peeve of mine. Any time there's a long list of items > > > (header file inclusions, kconfig entries, array initalisers, etc) and > > > someone wants to add a new item, they *always* go and stick it at the > > > end of the list. > > > > > > Guys, don't do this. Either put the new item into a randomly-chosen > > > position or, probably better, alphanumerically sort the list. > > > > > > lets sort all our select statements alphanumerically. This commit was > > > created by the following perl: > > > > I applied this and tried to configure the Nomadik defconfig, > > and I get this, sadly: > > Yes, I've just fixed those. Unfortunately, the patch is soo large that > it trips the mailing list size limit, and has to be manually approved, > so I'm not sure I can call on the list maintainers again today to do the > approval thing. After applying these two patches and manually running: $ git checkout-index -f arch/arm/mach-pxa/Kconfig $ git checkout-index -f arch/arm/mach-footbridge/Kconfig It builds just fine for omaps, so for omaps: Acked-by: Tony Lindgren