From: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
To: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mark Zhang <nvmarkzhang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 1/2] drm: constify edid handling functions
Date: Wed, 16 Jan 2013 16:23:56 +0100 [thread overview]
Message-ID: <20130116152355.GA965@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <1358347002-10999-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]
On Wed, Jan 16, 2013 at 03:36:41PM +0100, Lucas Stach wrote:
[...]
> @@ -705,7 +705,7 @@ static int standard_timing_level(struct edid *edid)
> * monitors fill with ascii space (0x20) instead.
> */
> static int
> -bad_std_timing(u8 a, u8 b)
> +bad_std_timing(const u8 a, const u8 b)
> {
> return (a == 0x00 && b == 0x00) ||
> (a == 0x01 && b == 0x01) ||
Was this intended to go in here?
> @@ -721,8 +721,8 @@ bad_std_timing(u8 a, u8 b)
> * and convert them into a real mode using CVT/GTF/DMT.
> */
> static struct drm_display_mode *
> -drm_mode_std(struct drm_connector *connector, struct edid *edid,
> - struct std_timing *t, int revision)
> +drm_mode_std(struct drm_connector *connector, const struct edid *edid,
> + const struct std_timing *t, int revision)
> {
> struct drm_device *dev = connector->dev;
> struct drm_display_mode *m, *mode = NULL;
I know I'm being picky, but you're constifying the t parameter here as
well without saying so in the commit message.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-01-16 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 14:36 [PATCH v2 1/2] drm: constify edid handling functions Lucas Stach
[not found] ` <1358347002-10999-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-01-16 14:36 ` [PATCH v2 2/2] drm: tegra: check HDMI sink capability Lucas Stach
[not found] ` <1358347002-10999-2-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-01-16 15:24 ` Thierry Reding
[not found] ` <20130116152421.GB965-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2013-01-16 16:05 ` Jon Mayo
2013-01-16 15:23 ` Thierry Reding [this message]
2013-01-16 16:03 ` [PATCH v2 1/2] drm: constify edid handling functions Lucas Stach
2013-01-16 17:04 ` Jani Nikula
[not found] ` <87fw21qctl.fsf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-01-16 18:45 ` Thierry Reding
2013-01-16 16:44 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130116152355.GA965@avionic-0098.adnet.avionic-design.de \
--to=thierry.reding-rm9k5ik7kjkj5m59nbduvrnah6klmebb@public.gmane.org \
--cc=dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nvmarkzhang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox