Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2114 bytes --]

Hi,

On Mon, Mar 11, 2013 at 11:02:43AM -0600, Stephen Warren wrote:
> >> On 03/08/2013 12:08 AM, Felipe Balbi wrote:
> >>> On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren
> >>> wrote:
> >>>> On 03/07/2013 08:45 AM, Felipe Balbi wrote:
> >>>>> this will make sure that we have sensible names for all
> >>>>> phy drivers. Current situation was already quite bad with
> >>>>> too generic names being used.
> >>>> 
> >>>> Is phy-$name specific enough? There are other types of PHY
> >>>> such as Ethernet, etc. What about phy-usb-$name?
> >>> 
> >>> we will be creating a generic (kernel-wide) phy layer, so I
> >>> guess that matters very little. Specially since we don't want
> >>> to be differentiating PHYs by their subsystem and rather by the
> >>> IP name (which means phy-tegra, phy-samsung, phy-omap, are all
> >>> 'wrong', but there were no better names).
> >>> 
> >>>> Venu, please comment on what conflicts, if any, this will
> >>>> cause with the patches you'll be sending to clean up the
> >>>> Tegra USB/PHY drivers. Thanks.
> >>> 
> >>> BTW, let's stop with the whole dependency between PHY driver 
> >>> cleanup and arch/arm/mach-tegra/, too many patches have gone 
> >>> upstream bypassing my tree. What we should be doing is figuring
> >>> out how to remove arch/ dependencies so that patches can go
> >>> upstream and not cause conflicts.
> >> 
> >> Unfortunately, there's no way to actually avoid the dependencies 
> >> themselves. The DT bindings and EHCI/PHY controller split are
> >> wrong, and need work on both the DT and drivers to fix.
> > 
> > but those changes don't need to come together, right ? I mean, for
> > the DT part you could add the bindings to driver A without removing
> > from driver B and span the changes accross 2 merge windows.
> 
> There is only a single driver. It's being reworked to support the new
> binding.

alright, so what's the problem of adding new binding without removing
old one for v3.10 and remove old on v3.11 ? It gives a 3 month grace
period for all boards to be converted, at least.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]