From: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
To: Andrew Chew <achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1 v2] ARM: dt: tegra114: add PWM nodes
Date: Tue, 12 Mar 2013 20:24:29 +0100 [thread overview]
Message-ID: <20130312192429.GA21924@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <1363045695-28874-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
On Mon, Mar 11, 2013 at 04:48:15PM -0700, Andrew Chew wrote:
[...]
> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
[...]
> + pwm0: pwm@7000a000 {
> + compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
> + reg = <0x7000a000 0x4>;
> + #pwm-cells = <2>;
> + clocks = <&tegra_car 17>;
> + status = "disabled";
> + };
> +
> + pwm1: pwm@7000a010 {
> + compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
> + reg = <0x7000a010 0x4>;
> + #pwm-cells = <2>;
> + clocks = <&tegra_car 17>;
> + status = "disabled";
> + };
> +
> + pwm2: pwm@7000a020 {
> + compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
> + reg = <0x7000a020 0x4>;
> + #pwm-cells = <2>;
> + clocks = <&tegra_car 17>;
> + status = "disabled";
> + };
> +
> + pwm3: pwm@7000a030 {
> + compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
> + reg = <0x7000a030 0x4>;
> + #pwm-cells = <2>;
> + clocks = <&tegra_car 17>;
> + status = "disabled";
> + };
Shouldn't these rather go into a single PWM node which provides 4 PWM
devices? Just like we do on Tegra20?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-03-12 19:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 23:48 [PATCH 1/1 v2] ARM: dt: tegra114: add PWM nodes Andrew Chew
[not found] ` <1363045695-28874-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-12 9:23 ` Hiroshi Doyu
[not found] ` <20130312112340.6d624df5dfe28c4b5b8157f5-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-12 18:29 ` Stephen Warren
2013-03-12 18:50 ` Stephen Warren
2013-03-12 19:24 ` Thierry Reding [this message]
[not found] ` <20130312192429.GA21924-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2013-03-12 19:34 ` Stephen Warren
[not found] ` <513F8363.8090908-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-12 20:38 ` Andrew Chew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312192429.GA21924@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding-rm9k5ik7kjkj5m59nbduvrnah6klmebb@public.gmane.org \
--cc=achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox