From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH 1/1] tps65090-charger: Fix AC detect Date: Sun, 9 Jun 2013 10:03:47 -0700 Message-ID: <20130609170347.GA23128@teo> References: <1370553163-31804-1-git-send-email-achew@nvidia.com> <51B2054B.7030609@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <51B2054B.7030609-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rhyland Klein Cc: Andrew Chew , "dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Fri, Jun 07, 2013 at 12:07:39PM -0400, Rhyland Klein wrote: > On 6/6/2013 5:12 PM, Andrew Chew wrote: > > The VACG interrupt was not being enabled. Thus, interrupts were never > > generated when AC status changes. In addition, interrupts were never > > cleared after taking and processing the interrupt. > > > > Added the register offset for the INTR_MASK register, since this is needed > > to unmask the VACG interrupt. > > > > Enabled the VACG interrupt in tps65090_config_charger(). > > > > Cleared interrupts after processing, in tps65090_charger_isr(). > > > > Also removed unused variable "enable" in tps65090_enable_charging(), > > and fixed a typo in one of the dev_err() prints. > > > > Signed-off-by: Andrew Chew > > --- > > Great! Tested and it works great on my Dalmore. > > Tested-by: Rhyland Klein > Acked-by: Rhyland Klein Applied, thanks! Anton