* [PATCH] clk: tegra: fix pllre initilization
@ 2013-06-05 14:21 Peter De Schrijver
[not found] ` <1370442111-13215-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Peter De Schrijver @ 2013-06-05 14:21 UTC (permalink / raw)
To: Peter De Schrijver
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
mturquette-QSEj5FYQhm4dnm+yROfE0A, Stephen Warren,
Prashant Gaikwad, linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
The PLLRE flags weren't set correctly. Fixed in this patch.
Signed-off-by: Peter De Schrijver <pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
drivers/clk/tegra/clk-pll.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
index 4293643..197074a 100644
--- a/drivers/clk/tegra/clk-pll.c
+++ b/drivers/clk/tegra/clk-pll.c
@@ -1424,7 +1424,7 @@ struct clk *tegra_clk_register_pllre(const char *name, const char *parent_name,
struct tegra_clk_pll *pll;
struct clk *clk;
- pll_flags |= TEGRA_PLL_HAS_LOCK_ENABLE;
+ pll_flags |= TEGRA_PLL_HAS_LOCK_ENABLE | TEGRA_PLL_LOCK_MISC;
pll = _tegra_init_pll(clk_base, pmc, fixed_rate, pll_params, pll_flags,
freq_table, lock);
if (IS_ERR(pll))
@@ -1451,7 +1451,6 @@ struct clk *tegra_clk_register_pllre(const char *name, const char *parent_name,
val &= ~BIT(29);
pll_writel_misc(val, pll);
- pll_flags |= TEGRA_PLL_LOCK_MISC;
clk = _tegra_clk_register_pll(pll, name, parent_name, flags,
&tegra_clk_pllre_ops);
if (IS_ERR(clk))
--
1.7.7.rc0.72.g4b5ea.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1370442111-13215-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] clk: tegra: fix pllre initilization [not found] ` <1370442111-13215-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> @ 2013-06-05 16:30 ` Stephen Warren 2013-06-12 0:45 ` Mike Turquette 1 sibling, 0 replies; 3+ messages in thread From: Stephen Warren @ 2013-06-05 16:30 UTC (permalink / raw) To: Peter De Schrijver Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, mturquette-QSEj5FYQhm4dnm+yROfE0A, Prashant Gaikwad, linux-tegra-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On 06/05/2013 08:21 AM, Peter De Schrijver wrote: > The PLLRE flags weren't set correctly. Fixed in this patch. Tested-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: tegra: fix pllre initilization [not found] ` <1370442111-13215-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2013-06-05 16:30 ` Stephen Warren @ 2013-06-12 0:45 ` Mike Turquette 1 sibling, 0 replies; 3+ messages in thread From: Mike Turquette @ 2013-06-12 0:45 UTC (permalink / raw) To: Peter De Schrijver Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Stephen Warren, Prashant Gaikwad, linux-tegra-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA Quoting Peter De Schrijver (2013-06-05 07:21:46) > The PLLRE flags weren't set correctly. Fixed in this patch. > > Signed-off-by: Peter De Schrijver <pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Taken into clk-next. Thanks, Mike > --- > drivers/clk/tegra/clk-pll.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c > index 4293643..197074a 100644 > --- a/drivers/clk/tegra/clk-pll.c > +++ b/drivers/clk/tegra/clk-pll.c > @@ -1424,7 +1424,7 @@ struct clk *tegra_clk_register_pllre(const char *name, const char *parent_name, > struct tegra_clk_pll *pll; > struct clk *clk; > > - pll_flags |= TEGRA_PLL_HAS_LOCK_ENABLE; > + pll_flags |= TEGRA_PLL_HAS_LOCK_ENABLE | TEGRA_PLL_LOCK_MISC; > pll = _tegra_init_pll(clk_base, pmc, fixed_rate, pll_params, pll_flags, > freq_table, lock); > if (IS_ERR(pll)) > @@ -1451,7 +1451,6 @@ struct clk *tegra_clk_register_pllre(const char *name, const char *parent_name, > val &= ~BIT(29); > pll_writel_misc(val, pll); > > - pll_flags |= TEGRA_PLL_LOCK_MISC; > clk = _tegra_clk_register_pll(pll, name, parent_name, flags, > &tegra_clk_pllre_ops); > if (IS_ERR(clk)) > -- > 1.7.7.rc0.72.g4b5ea.dirty ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-12 0:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-05 14:21 [PATCH] clk: tegra: fix pllre initilization Peter De Schrijver
[not found] ` <1370442111-13215-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-05 16:30 ` Stephen Warren
2013-06-12 0:45 ` Mike Turquette
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox