Re: [PATCH] tegrarcm: Add version command

[Allen Martin <amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]

On Mon, Jun 17, 2013 at 08:58:57PM -0700, Stephen Warren wrote:
> On 06/17/2013 09:24 PM, Allen Martin wrote:
> > Add command line option "--version" that prints the version number and
> > exits.
> 
> Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> I assume you'll apply all these.

yes

> 
> Although...
> 
> > +static void print_version(char *progname)
> > +{
> > +	fprintf(stderr, "%s %s\n", PACKAGE_NAME, PACKAGE_VERSION);
> > +}
> 
> I wonder if that shouldn't print to stdout; it's the requested output of
> the command, not some error message.

Sounds reasonable.

-Allen
-- 
nvpublic