public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Allen Martin <amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] tegrarcm: Add SPI flash support to tegra114 miniloader
Date: Mon, 17 Jun 2013 21:55:36 -0700	[thread overview]
Message-ID: <20130618045536.GC8973@badger> (raw)
In-Reply-To: <51BFDAA7.1080106-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>

On Mon, Jun 17, 2013 at 08:57:27PM -0700, Stephen Warren wrote:
> On 06/17/2013 09:26 PM, Allen Martin wrote:
> > Update tegra114 miniloader file with a version that supports boot from
> > SPI flash.  The previous version would hang if the board was
> > configured to boot from SPI.
> 
> Out of curiosity, why does it hang? I thought the miniloader would only
> interpret the SDRAM portion of the BCT, and hence the boot flash
> configuration would have no effect on it at all. Does it also enable
> whatever boot flash is in the BCT too?
> 
> Either way, I guess I have no problem with the patch, so,
> Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Miniloader is AOS based, like fastboot.  This was a bug in the AOS
implementation of SPI which I think was still using a t30 style "slink"
driver on t114.

I don't know all the details but I would guess miniloader assumes
you're about to write to the boot device so it applies the boot device
timing parameters in the BCT to make sure it's running at greater than
the bootROM failsafe clocks.

-Allen
-- 
nvpublic

      parent reply	other threads:[~2013-06-18  4:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1371525987-2799-1-git-send-email-amartin@nvidia.com>
     [not found] ` <1371525987-2799-1-git-send-email-amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-18  3:57   ` [PATCH] tegrarcm: Add SPI flash support to tegra114 miniloader Stephen Warren
     [not found]     ` <51BFDAA7.1080106-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-18  4:55       ` Allen Martin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130618045536.GC8973@badger \
    --to=amartin-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox