From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] ARM: tegra: Fix Beaver's PCIe lane configuration
Date: Sat, 22 Jun 2013 12:45:45 +0200 [thread overview]
Message-ID: <20130622104545.GA15586@manwe> (raw)
In-Reply-To: <1371846232-31163-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]
On Fri, Jun 21, 2013 at 02:23:52PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Beaver's PCIe lane configuration most closely matches x2 x2 x2 rather
> than x4 x1 x1, since clocks 0 and 2 are used, and lanes 0 and 5 are used,
> and the only way those align is with a x2 x2 x2 configuration.
Looking at the schematics again I have to agree. Thanks for catching
this.
> Also, disable root port 1; there's nothing connected to it. Root port 0
> is the on-board PCIe Ethernet, and port 2 is the mini-PCIe slot.
>
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> This is to be applied to Thierry's WIP PCIe driver branch.
I've applied this to my tegra/next branch and will squash it into the
Beaver patch that's already there.
You mention another fix that might be required for PCIe on Tegra30
(additional write to the PADS_REFCLK_CFG1) register. Did that turn out
to fix communication of the third port?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-06-22 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 20:23 [PATCH] ARM: tegra: Fix Beaver's PCIe lane configuration Stephen Warren
[not found] ` <1371846232-31163-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-22 10:45 ` Thierry Reding [this message]
2013-06-24 4:21 ` Stephen Warren
[not found] ` <51C7C933.7020600-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-24 20:56 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130622104545.GA15586@manwe \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox