[PATCH 18/23] iommu/tegra: smmu: Workaround PCIe IOMMU'able

[PATCH 18/23] iommu/tegra: smmu: Workaround PCIe IOMMU'able

[Hiroshi Doyu]

Make PCIe work as it is. IOMMU support can be implemented later.

Signed-off-by: Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 drivers/iommu/tegra-smmu.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
index 64da08a..6e82df3 100644
--- a/drivers/iommu/tegra-smmu.c
+++ b/drivers/iommu/tegra-smmu.c
@@ -402,6 +402,9 @@ static int __smmu_client_set_hwgrp(struct smmu_client *c,
 
 	for_each_set_bit(i, (unsigned long *)&map,
 			 sizeof(map) * BITS_PER_BYTE) {
+		if (i == SWGID_AFI) /* FIXME: IOMMU'able PCIe */
+			continue;
+
 		offs = HWGRP_ASID_REG(i);
 		val = smmu_read(smmu, offs);
 		if (on) {
-- 
1.8.1.5

Re: [PATCH 18/23] iommu/tegra: smmu: Workaround PCIe IOMMU'able

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

On Wed, Jun 26, 2013 at 12:28:21PM +0300, Hiroshi Doyu wrote:
> Make PCIe work as it is. IOMMU support can be implemented later.
> 
> Signed-off-by: Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/iommu/tegra-smmu.c | 3 +++
>  1 file changed, 3 insertions(+)

Can you provide more information about what the problem is here? Why is
PCIe not working when mapped through the IOMMU?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 18/23] iommu/tegra: smmu: Workaround PCIe IOMMU'able

[Hiroshi Doyu]

Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote @ Wed, 26 Jun 2013 13:06:27 +0200:

> * PGP Signed by an unknown key
> 
> On Wed, Jun 26, 2013 at 12:28:21PM +0300, Hiroshi Doyu wrote:
> > Make PCIe work as it is. IOMMU support can be implemented later.
> > 
> > Signed-off-by: Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> > ---
> >  drivers/iommu/tegra-smmu.c | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> Can you provide more information about what the problem is here? Why is
> PCIe not working when mapped through the IOMMU?

I haven't had a code to register PCI device as IOMMU'able as
ops->add_device() does for platform_devices. I'll add this comment.

Re: [PATCH 18/23] iommu/tegra: smmu: Workaround PCIe IOMMU'able

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

On Wed, Jun 26, 2013 at 01:09:06PM +0200, Hiroshi Doyu wrote:
> Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote @ Wed, 26 Jun 2013 13:06:27 +0200:
> 
> > * PGP Signed by an unknown key
> > 
> > On Wed, Jun 26, 2013 at 12:28:21PM +0300, Hiroshi Doyu wrote:
> > > Make PCIe work as it is. IOMMU support can be implemented later.
> > > 
> > > Signed-off-by: Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> > > ---
> > >  drivers/iommu/tegra-smmu.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > 
> > Can you provide more information about what the problem is here? Why is
> > PCIe not working when mapped through the IOMMU?
> 
> I haven't had a code to register PCI device as IOMMU'able as
> ops->add_device() does for platform_devices. I'll add this comment.

Okay, that should be solved then when we merge the PCIe driver. I hope
that can happen soon.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]