Re: [PATCH 1/1] ARM: tegra: Add basic support for carma devkit

[Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2160 bytes --]

On Thu, Jun 27, 2013 at 11:51:20AM -0600, Stephen Warren wrote:
> On 06/27/2013 10:59 AM, Eric Brower wrote:
> > On 06/23/2013 06:38 AM, Chris Desjardins wrote:
> >>
> >> Signed-off-by: Chris Desjardins <chris.desjardins-8HJrC8Or5ylBDgjK7y7TUQ@public.gmane.org>
> >> ---
> >>   arch/arm/boot/dts/tegra30-carma.dts |  461
> >> +++++++++++++++++++++++++++++++++++
> >>   1 file changed, 461 insertions(+)
> >>   create mode 100644 arch/arm/boot/dts/tegra30-carma.dts
> >>
> >> diff --git a/arch/arm/boot/dts/tegra30-carma.dts
> >> b/arch/arm/boot/dts/tegra30-carma.dts
> >> new file mode 100644
> >> index 0000000..e88134e
> >> --- /dev/null
> >> +++ b/arch/arm/boot/dts/tegra30-carma.dts
> >> @@ -0,0 +1,461 @@
> >> +/dts-v1/;
> >> +#include "tegra30.dtsi"
> >> +
> >> +/**
> >> + * This file contains common DT entry for Carma
> >> + */
> >> +
> >> +/ {
> >> +       model = "NVIDIA Tegra30 Carma evaluation board";
> >> +       compatible = "nvidia,carma", "nvidia,tegra30";
> > 
> > Chris,
> > 
> > This is not an NVIDIA board, it's a Seco board.  I'd suggest:
> > 
> > model = "Seco Tegra30 Carma development board";
> > compatible = "seco,carma", "nvidia,tegra30";
> > 
> > But you might want to check with Seco regarding preference of prefix for
> > "seco,carma" above.  I see no precedent for it after a quick check.
> 
> That's a good point. The seco prefix should be added to
> Documentation/devicetree/bindings/vendor-prefixes.txt. I believe the
> rule for vendor prefixes is to use the company's stock ticker symbol if
> there is one and it makes sense, else fall back to name. "seco" is short
> enough it's probably fine either way.

Seco is a privately held company so there's no stock ticker symbol. Also
the canonical spelling seems to be "SECO" and their website lists the
device as "CARMA DevKit" or "CUDA on ARM DevKit", so perhaps model
should be something like:

	model = "SECO CARMA DevKit";

or

	model = "SECO CUDA on ARM DevKit";

The fact that it's based on Tegra30 becomes clear by looking at the
compatible and doesn't necessarily need to go into the model string.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]