From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Subject: Re: [PATCH 07/32] arm: delete __cpuinit/__CPUINIT usage from all ARM users Date: Tue, 2 Jul 2013 13:53:00 -0400 Message-ID: <20130702175257.GC21817@windriver.com> References: <1372102237-8757-1-git-send-email-paul.gortmaker@windriver.com> <1372102237-8757-8-git-send-email-paul.gortmaker@windriver.com> <1372755120.2874.18.camel@jlo-ubuntu-64.nvidia.com> <20130702085818.GD24642@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20130702085818.GD24642-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Russell King - ARM Linux Cc: Joseph Lo , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Will Deacon , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org [Re: [PATCH 07/32] arm: delete __cpuinit/__CPUINIT usage from all ARM users] On 02/07/2013 (Tue 09:58) Russell King - ARM Linux wrote: > On Tue, Jul 02, 2013 at 04:52:00PM +0800, Joseph Lo wrote: > > I just tested this series on Tegra platform. It looks broken CPU hotplug > > function for Tegra at least. The CPU can't plug-in after unplugging. And > > the system resume function also not working when "enable_nonboot_cpus". > > > > Both of the issue cause system hang up. Are we missing something for > > __cpuinit removal work? > > Check that any assembly code you're using where the __CPUINIT* marker has > been removed is not preceded by an __INIT or similar. This code needs > to end up in the normal .text, .data or .bss sections now. Yes, As Russell says it is entirely possible that the earlier section was __INIT and there was already a missing __FINIT (or .previous). Hence what was __cpuinit got grandfathered into __INIT instead of .text/.data/.bss I'm offline at the moment but will double check myself later this evening if nothing obvious has been found by then. Thanks, Paul. --