Re: [PATCH v2 6/6] usb: host: tegra: Tegra30 support

[Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

On Tue, Aug 06, 2013 at 11:27:11PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 08/06/2013 11:16 PM, Tuomas Tynkkynen wrote:
> 
> >[...]
> 
> >>>+	match = of_match_device(tegra_ehci_of_match, &pdev->dev);
> >>>+	if (!match) {
> >>>+		dev_err(&pdev->dev, "Error: No device match found\n");
> >>>+		return -ENODEV;
> >>>+	}
> >>>+	soc_config = (struct tegra_ehci_soc_config *)match->data;
> 
> >>     Aren't casts from 'const void *' automatic?
> 
> >>WBR, Sergei
> 
> >Indeed they are, but those explicit casts seem to be used in many places in the kernel.
> 
>    I suspect people just don't know C well enough. They are also
> being gradually removed.

yeah, please resend with the cast removed. Also, put Tested-by, Acked-by
and Reviewed-by in place.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]