From mboxrd@z Thu Jan 1 00:00:00 1970 From: Allen Martin Subject: Re: [PATCH tegra-cbootimage] Add automake option subdir-objects to prevent warnings Date: Mon, 19 Aug 2013 13:08:22 -0700 Message-ID: <20130819200822.GA13707@badger> References: <20130723154918.GB2864@dhcp-172-17-186-34.nvidia.com> <51FAC272.8040105@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: In-Reply-To: <51FAC272.8040105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Content-Disposition: inline Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Stefan Agner , Thierry Reding , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Thu, Aug 01, 2013 at 01:17:54PM -0700, Stephen Warren wrote: > On 07/23/2013 09:49 AM, Thierry Reding wrote: > > On Sun, Jul 21, 2013 at 11:25:28PM +0200, Stefan Agner wrote: > >> The SoC specific code is in subdirectories which leads to > >> warnings in newer automake versions. The option subdir-objects > >> prevents those warnings. > >> > >> Signed-off-by: Stefan Agner --- src/Makefile.am > >> | 2 ++ 1 file changed, 2 insertions(+) > >> > >> diff --git a/src/Makefile.am b/src/Makefile.am index > >> 6fcc0d8..6fecfc7 100644 --- a/src/Makefile.am +++ > >> b/src/Makefile.am @@ -1,3 +1,5 @@ +AUTOMAKE_OPTIONS = > >> subdir-objects + AM_CFLAGS = -Wall -std=c99 > >> > >> bin_PROGRAMS = cbootimage bct_dump > > > > Hi Stefan, > > > > Thanks for the patch. Generally this looks good to me, though > > automake now complains: > > > > src/Makefile.am:36: compiling `t114/parse_t114.c' in subdir > > requires `AM_PROG_CC_C_O' in `configure.ac' > > > > Which can quite easily be solved by adding that line in > > configure.ac. Immediately following the AC_PROG_CC looks like a > > good place for it. > > Stefan, are you planning on revising the patch based on Thierry's > suggestion? Hi, what's the status of this patch? Is there a version 2 to review? -Allen -- nvpublic