From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org
Subject: Re: [PATCH v2 tegra-cbootimage] Add automake option subdir-objects to prevent warnings
Date: Mon, 19 Aug 2013 22:33:17 +0200 [thread overview]
Message-ID: <20130819203316.GE5191@mithrandir> (raw)
In-Reply-To: <c0f44202ad8a959b1bd4c93f43c1dc42-XLVq0VzYD2Y@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]
On Mon, Aug 19, 2013 at 10:10:20PM +0200, Stefan Agner wrote:
> The SoC specific code is in subdirectories which leads to warnings in
> newer
> automake versions. The option subdir-objects prevents those warnings.
>
> Signed-off-by: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
> ---
>
> Sorry, was in vacation. I could not reproduce the message Thierry sees
> on
> my automake 1.14 installation, however, the option make sense as far as
> I
> understand its meaning.
Yes, automake 1.14 doesn't warn about it, presumably because it makes
sure to select AM_PROG_CC_C_O if subdir-objects is enabled. I can
reproduce the warning by downgrading to 1.13.4, though.
> configure.ac | 1 +
> src/Makefile.am | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index ccd0a55..9b83a21 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -10,6 +10,7 @@ AC_CONFIG_HEADERS([config.h])
> # Checks for programs.
> AC_PROG_CXX
> AC_PROG_CC
> +AM_PROG_CC_C_O
> PKG_PROG_PKG_CONFIG
>
> # Checks for libraries.
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 6fcc0d8..6fecfc7 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -1,3 +1,5 @@
> +AUTOMAKE_OPTIONS = subdir-objects
> +
I don't remember if I mentioned it before, but I've seen a lot of
projects that keep these options in the configure.ac file (in the
AM_INIT_AUTOMAKE command). The GNU documentation isn't specific
about which variant is preferred, so either way:
Reviewed-by: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-19 20:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 20:10 [PATCH v2 tegra-cbootimage] Add automake option subdir-objects to prevent warnings Stefan Agner
[not found] ` <c0f44202ad8a959b1bd4c93f43c1dc42-XLVq0VzYD2Y@public.gmane.org>
2013-08-19 20:33 ` Thierry Reding [this message]
2013-08-19 21:01 ` Stephen Warren
2013-08-23 16:50 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130819203316.GE5191@mithrandir \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stefan-XLVq0VzYD2Y@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).