tegra on 3.11

tegra on 3.11

[Kyle McMartin]

Hey guys,

Just a quick note, I needed to pull in the patch from
http://marc.info/?l=linux-tegra&m=137404750420372&w=2 in order to get
trimslice booting from its internal SATA when using dtb to boot.

--Kyle

Re: tegra on 3.11

[Stephen Warren]

On 08/20/2013 09:04 AM, Kyle McMartin wrote:
> Hey guys,
> 
> Just a quick note, I needed to pull in the patch from
> http://marc.info/?l=linux-tegra&m=137404750420372&w=2 in order to get
> trimslice booting from its internal SATA when using dtb to boot.

Oh dear, I can reproduce this. It looks like I didn't notice this since
I was probably testing linux-next with Mikko's patches applied on top in
my local branch:-(

If that patch gets applied to v3.11, then it'll cause nasty merge
conflicts with Mikko's other USB-related patches when v3.12 comes
around. Plus, the patch is rather large for this late stage in the
v3.11-rc series. I think the best way is to add regulator-always-on,
regulator-boot-on properties to the relevant VBUS regulators. I'll try
sending a patch for that...

Re: tegra on 3.11

[Kyle McMartin]

On Tue, Aug 20, 2013 at 01:18:10PM -0600, Stephen Warren wrote:
> On 08/20/2013 09:04 AM, Kyle McMartin wrote:
> > Hey guys,
> > 
> > Just a quick note, I needed to pull in the patch from
> > http://marc.info/?l=linux-tegra&m=137404750420372&w=2 in order to get
> > trimslice booting from its internal SATA when using dtb to boot.
> 
> Oh dear, I can reproduce this. It looks like I didn't notice this since
> I was probably testing linux-next with Mikko's patches applied on top in
> my local branch:-(
> 
> If that patch gets applied to v3.11, then it'll cause nasty merge
> conflicts with Mikko's other USB-related patches when v3.12 comes
> around. Plus, the patch is rather large for this late stage in the
> v3.11-rc series. I think the best way is to add regulator-always-on,
> regulator-boot-on properties to the relevant VBUS regulators. I'll try
> sending a patch for that...

Thanks, we've hit another issue in Fedora where that may or may not be
the kernel (life on the bleeding edge, sigh.) but I'll re-build a known
working kernel with your patch instead of the backport and let you know
if it works for us.

regards, Kyle

Re: tegra on 3.11

[Kyle McMartin]

> > [   29.198018] PCI: enabling device 0000:01:00.0 (0140 -> 0143)
> > [   29.198180] Unhandled fault: imprecise external abort (0x406) at
> > 0xb6f49000
> > [   29.205136] Internal error: : 406 [#1] SMP ARM
> > 
> > looks to be the first time we touch the HW in rtl_init_one.
> > 
> > Seen anything similar, or should I start debugging further?
> 
> PCIe isn't expected to work usefully until 3.12, unless you've manually
> merged in Thierry's Tegra PCIe driver rewrite. It's probably worth
> disabling it in your .config file.

fwiw, the problem was CONFIG_PCIEPORTBUS in our config, I've not had
a chance to track down what the issue actually is, but that driver
busted things in 3.11.

regards, Kyle

Re: tegra on 3.11

[Stephen Warren]

On 09/04/2013 12:38 PM, Kyle McMartin wrote:
>>> [   29.198018] PCI: enabling device 0000:01:00.0 (0140 -> 0143)
>>> [   29.198180] Unhandled fault: imprecise external abort (0x406) at
>>> 0xb6f49000
>>> [   29.205136] Internal error: : 406 [#1] SMP ARM
>>>
>>> looks to be the first time we touch the HW in rtl_init_one.
>>>
>>> Seen anything similar, or should I start debugging further?
>>
>> PCIe isn't expected to work usefully until 3.12, unless you've manually
>> merged in Thierry's Tegra PCIe driver rewrite. It's probably worth
>> disabling it in your .config file.
> 
> fwiw, the problem was CONFIG_PCIEPORTBUS in our config, I've not had
> a chance to track down what the issue actually is, but that driver
> busted things in 3.11.

Ah, I guess if you build the R8169 driver as a module, and disable
CONFIG_CPU_IDLE, then it will work fine on TrimSlice in v3.11.

I have reproduced the issue you see with CONFIG_PCIEPORTBUS in v3.11.
So, at least it isn't an isolated incident. That said, I don't intend to
look into it since there's an easy workaround, and ...

The good news is that in v3.12 with the new PCIe driver,

(a) You don't need to build R8169 as a module; built-in will work fine.

(b) You don't need to disable CPUIDLE; the code disables the problematic
idle state automatically iff a PCIe device is detected.

(c) CONFIG_PCIEPORTBUS is enabled in tegra_defconfig, and everything
still works fine.

Re: tegra on 3.11

[Kyle McMartin]

On Thu, Sep 05, 2013 at 03:14:23PM -0600, Stephen Warren wrote:
> Ah, I guess if you build the R8169 driver as a module, and disable
> CONFIG_CPU_IDLE, then it will work fine on TrimSlice in v3.11.
> 
> I have reproduced the issue you see with CONFIG_PCIEPORTBUS in v3.11.
> So, at least it isn't an isolated incident. That said, I don't intend to
> look into it since there's an easy workaround, and ...
> 
> The good news is that in v3.12 with the new PCIe driver,
> 
> (a) You don't need to build R8169 as a module; built-in will work fine.
> 
> (b) You don't need to disable CPUIDLE; the code disables the problematic
> idle state automatically iff a PCIe device is detected.
> 
> (c) CONFIG_PCIEPORTBUS is enabled in tegra_defconfig, and everything
> still works fine.
> 

Awesome. Thanks very much Stephen, I'll make those changes to our
3.12 snapshots.

--Kyle

Re: tegra on 3.11

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 980 bytes --]

On Wed, Sep 04, 2013 at 02:38:15PM -0400, Kyle McMartin wrote:
> > > [   29.198018] PCI: enabling device 0000:01:00.0 (0140 -> 0143)
> > > [   29.198180] Unhandled fault: imprecise external abort (0x406) at
> > > 0xb6f49000
> > > [   29.205136] Internal error: : 406 [#1] SMP ARM
> > > 
> > > looks to be the first time we touch the HW in rtl_init_one.
> > > 
> > > Seen anything similar, or should I start debugging further?
> > 
> > PCIe isn't expected to work usefully until 3.12, unless you've manually
> > merged in Thierry's Tegra PCIe driver rewrite. It's probably worth
> > disabling it in your .config file.
> 
> fwiw, the problem was CONFIG_PCIEPORTBUS in our config, I've not had
> a chance to track down what the issue actually is, but that driver
> busted things in 3.11.

I came across another occurrence of this only recently and now stumbled
across this old email. Did you by any chance find out what the issue is
with PCIEPORTBUS?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: tegra on 3.11

[Kyle McMartin]

On Tue, Dec 03, 2013 at 11:30:45AM +0100, Thierry Reding wrote:
> On Wed, Sep 04, 2013 at 02:38:15PM -0400, Kyle McMartin wrote:
> > > > [   29.198018] PCI: enabling device 0000:01:00.0 (0140 -> 0143)
> > > > [   29.198180] Unhandled fault: imprecise external abort (0x406) at
> > > > 0xb6f49000
> > > > [   29.205136] Internal error: : 406 [#1] SMP ARM
> > > > 
> > > > looks to be the first time we touch the HW in rtl_init_one.
> > > > 
> > > > Seen anything similar, or should I start debugging further?
> > > 
> > > PCIe isn't expected to work usefully until 3.12, unless you've manually
> > > merged in Thierry's Tegra PCIe driver rewrite. It's probably worth
> > > disabling it in your .config file.
> > 
> > fwiw, the problem was CONFIG_PCIEPORTBUS in our config, I've not had
> > a chance to track down what the issue actually is, but that driver
> > busted things in 3.11.
> 
> I came across another occurrence of this only recently and now stumbled
> across this old email. Did you by any chance find out what the issue is
> with PCIEPORTBUS?
> 

I think I did -- let me try to dig through my notes next time I'm in the
office and I'll follow up later this week.

Thanks!
 Kyle