* [patch 2/2] gpu: host1x: returning success instead of -ENOMEM
@ 2013-08-23 10:19 Dan Carpenter
[not found] ` <20130823101911.GA1824-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2013-08-27 9:07 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-08-23 10:19 UTC (permalink / raw)
To: Thierry Reding
Cc: Terje Bergström, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
There is a mistake here so it returns PTR_ERR(NULL) which is success
instead of -ENOMEM.
Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
I can't compile this.
diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c
index cc80766..6cf41da 100644
--- a/drivers/gpu/host1x/job.c
+++ b/drivers/gpu/host1x/job.c
@@ -466,9 +466,8 @@ static inline int copy_gathers(struct host1x_job *job, struct device *dev)
&job->gather_copy,
GFP_KERNEL);
if (!job->gather_copy_mapped) {
- int err = PTR_ERR(job->gather_copy_mapped);
job->gather_copy_mapped = NULL;
- return err;
+ return -ENOMEM;
}
job->gather_copy_size = size;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch 2/2] gpu: host1x: returning success instead of -ENOMEM
[not found] ` <20130823101911.GA1824-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
@ 2013-08-23 19:16 ` Stephen Warren
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Warren @ 2013-08-23 19:16 UTC (permalink / raw)
To: Dan Carpenter
Cc: Thierry Reding, Terje Bergström,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On 08/23/2013 04:19 AM, Dan Carpenter wrote:
> There is a mistake here so it returns PTR_ERR(NULL) which is success
> instead of -ENOMEM.
>
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
> I can't compile this.
For the record, just do:
export CROSS_COMPILE=xxx
make ARCH=arm tegra_defconfig
make ARCH=arm zImage
The only slightly difficult part is getting a CROSS_COMPILE value. Many
distros ship at least some ARM cross-compiler in their standard
package-set these days, and if not, you can download the Linaro
compilers or go to ftp://ftp.kernel.org/pub/tools/crosstool/index.html.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 2/2] gpu: host1x: returning success instead of -ENOMEM
2013-08-23 10:19 [patch 2/2] gpu: host1x: returning success instead of -ENOMEM Dan Carpenter
[not found] ` <20130823101911.GA1824-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
@ 2013-08-27 9:07 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2013-08-27 9:07 UTC (permalink / raw)
To: Dan Carpenter
Cc: Terje Bergström, dri-devel, linux-tegra, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
On Fri, Aug 23, 2013 at 01:19:11PM +0300, Dan Carpenter wrote:
> There is a mistake here so it returns PTR_ERR(NULL) which is success
> instead of -ENOMEM.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I can't compile this.
Good catch! Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-27 9:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-23 10:19 [patch 2/2] gpu: host1x: returning success instead of -ENOMEM Dan Carpenter
[not found] ` <20130823101911.GA1824-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2013-08-23 19:16 ` Stephen Warren
2013-08-27 9:07 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).