Re: [PATCH 7/9] ARM: tegra: Enable DSI support on Dalmore

[Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

On Mon, Oct 07, 2013 at 03:25:52PM -0600, Stephen Warren wrote:
> On 10/07/2013 05:48 AM, Thierry Reding wrote:
> > Dalmore has a 10.1" WUXGA panel connected to one of the DSI outputs of
> > the Tegra114.
> 
> > diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> 
> > -		lcd_bl_en_reg: regulator@2 {
> > +		usb1_vbus_reg: regulator@2 {
> >  			compatible = "regulator-fixed";
> >  			reg = <2>;
> > -			regulator-name = "lcd_bl_en";
> > -			regulator-min-microvolt = <5000000>;
> > -			regulator-max-microvolt = <5000000>;
> > -			enable-active-high;
> > -			gpio = <&gpio TEGRA_GPIO(H, 2) GPIO_ACTIVE_HIGH>;
> > -		};
> > -
> > -		usb1_vbus_reg: regulator@3 {
> > -			compatible = "regulator-fixed";
> > -			reg = <3>;
> >  			regulator-name = "usb1_vbus";
> >  			regulator-min-microvolt = <5000000>;
> >  			regulator-max-microvolt = <5000000>;
> 
> Rather than renumbering all the regulators, can you just delete the one
> regulator and leave a gap in the numbering? That'd make the diff a lot
> smaller and clearer. There's no need for the reg values to be contiguous
> here, so I don't think the renumbering is useful in-and-of-itself.

Okay, I've reverted the renumbering changes.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]