From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter De Schrijver Subject: Re: [PATCH 4/5] clk: tegra124: Add new peripheral clocks Date: Thu, 10 Oct 2013 11:51:36 +0300 Message-ID: <20131010085136.GP4233@tbergstrom-lnx.Nvidia.com> References: <1380878014-22088-1-git-send-email-pdeschrijver@nvidia.com> <1380878014-22088-5-git-send-email-pdeschrijver@nvidia.com> <525487C7.6080103@wwwdotorg.org> <20131009081123.GB3973@tbergstrom-lnx.Nvidia.com> <52557D92.9050200@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <52557D92.9050200-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Mike Turquette , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Prashant Gaikwad , Thierry Reding , Paul Walmsley , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Wed, Oct 09, 2013 at 06:00:18PM +0200, Stephen Warren wrote: > On 10/09/2013 02:11 AM, Peter De Schrijver wrote: > > On Wed, Oct 09, 2013 at 12:31:35AM +0200, Stephen Warren wrote: > >> On 10/04/2013 03:12 AM, Peter De Schrijver wrote: > >>> Tegra124 introduces a number of new peripheral clocks. This patch adds those > >>> to the common peripheral clock code. > >> > >> Don't you need to add AFC[0..5] in this patch and/or patch 5? > > > > AFC[0..5] are reset only nodes afaik. Up to now, we haven't done that. > > The goal is to include them once we move to the reset framework. > > No, we've always added clock entries for all reset-only clocks into the > clock driver. Since the port to the reset framework is not available > yet, we need to continue to do this. Otherwise, we won't be able to > upstream audio support. > The only clock which required this up to now was 'cop' (avp). Which is not in upstream. Cheers, Peter.