From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] spi/tegra20-slink: Crude refactoring to use core message parsing
Date: Wed, 16 Oct 2013 23:02:55 +0100 [thread overview]
Message-ID: <20131016220255.GG2443@sirena.org.uk> (raw)
In-Reply-To: <525F081F.1080601-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
On Wed, Oct 16, 2013 at 03:41:51PM -0600, Stephen Warren wrote:
> On 10/16/2013 03:00 PM, Mark Brown wrote:
> > -static int tegra_slink_transfer_one_message(struct spi_master *master,
> > - struct spi_message *msg)
> ...
> > - msg->actual_length += xfer->len;
> > - if (xfer->cs_change && xfer->delay_usecs) {
> > - tegra_slink_writel(tspi, tspi->def_command_reg,
> > - SLINK_COMMAND);
> > - udelay(xfer->delay_usecs);
> > - }
> That chunk didn't seem to end up anywhere else. Is that expected?
It should be handled by framework code and it's buggy anyway, the two
fields are not connected and cs_change looks awfully like it'd at best
only work the first time it's used.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-10-16 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 21:00 [PATCH 1/2] spi/tegra20-slink: Crude refactoring to use core message parsing Mark Brown
[not found] ` <1381957255-24344-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-10-16 21:00 ` [PATCH 2/2] spi/tegra20-slink: Move first transfer preparation to prepare_message Mark Brown
2013-10-16 21:41 ` [PATCH 1/2] spi/tegra20-slink: Crude refactoring to use core message parsing Stephen Warren
[not found] ` <525F081F.1080601-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-16 22:02 ` Mark Brown [this message]
2013-10-16 22:08 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016220255.GG2443@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox