* [PATCH -next] drm/tegra: add missing clk_disable_unprepare() on error in gr2d_probe()
@ 2013-10-21 5:38 Wei Yongjun
[not found] ` <CAPgLHd_iff-PXrhOrVKi_qsqsBU7Yx0MByJDr_3_2fpJ8QwETQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2013-10-21 5:38 UTC (permalink / raw)
To: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
tbergstrom-DDmLM1+adcrQT0dZR+AlfA, airlied-cv59FeDIM0c,
swarren-3lzwWm7+Weoh9ZMKESR00Q,
grant.likely-QSEj5FYQhm4dnm+yROfE0A,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ
Cc: yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
Add the missing clk_disable_unprepare() before return
from gr2d_probe() in the error handling case.
Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
---
drivers/gpu/drm/tegra/gr2d.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c
index 73b79ba..7f4eb11 100644
--- a/drivers/gpu/drm/tegra/gr2d.c
+++ b/drivers/gpu/drm/tegra/gr2d.c
@@ -186,6 +186,7 @@ static int gr2d_probe(struct platform_device *pdev)
err = host1x_client_register(&gr2d->client.base);
if (err < 0) {
dev_err(dev, "failed to register host1x client: %d\n", err);
+ clk_disable_unprepare(gr2d->clk);
return err;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <CAPgLHd_iff-PXrhOrVKi_qsqsBU7Yx0MByJDr_3_2fpJ8QwETQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH -next] drm/tegra: add missing clk_disable_unprepare() on error in gr2d_probe() [not found] ` <CAPgLHd_iff-PXrhOrVKi_qsqsBU7Yx0MByJDr_3_2fpJ8QwETQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2013-10-28 8:33 ` Terje Bergström 2013-10-28 8:54 ` Thierry Reding 1 sibling, 0 replies; 3+ messages in thread From: Terje Bergström @ 2013-10-28 8:33 UTC (permalink / raw) To: Wei Yongjun, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org Cc: yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 21.10.2013 08:38, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org> > > Add the missing clk_disable_unprepare() before return > from gr2d_probe() in the error handling case. > > Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org> > --- > drivers/gpu/drm/tegra/gr2d.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c > index 73b79ba..7f4eb11 100644 > --- a/drivers/gpu/drm/tegra/gr2d.c > +++ b/drivers/gpu/drm/tegra/gr2d.c > @@ -186,6 +186,7 @@ static int gr2d_probe(struct platform_device *pdev) > err = host1x_client_register(&gr2d->client.base); > if (err < 0) { > dev_err(dev, "failed to register host1x client: %d\n", err); > + clk_disable_unprepare(gr2d->clk); > return err; > } > > Looks good. Reviewed-by: Terje Bergstrom <tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Terje ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/tegra: add missing clk_disable_unprepare() on error in gr2d_probe() [not found] ` <CAPgLHd_iff-PXrhOrVKi_qsqsBU7Yx0MByJDr_3_2fpJ8QwETQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2013-10-28 8:33 ` Terje Bergström @ 2013-10-28 8:54 ` Thierry Reding 1 sibling, 0 replies; 3+ messages in thread From: Thierry Reding @ 2013-10-28 8:54 UTC (permalink / raw) To: Wei Yongjun Cc: tbergstrom-DDmLM1+adcrQT0dZR+AlfA, airlied-cv59FeDIM0c, swarren-3lzwWm7+Weoh9ZMKESR00Q, grant.likely-QSEj5FYQhm4dnm+yROfE0A, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, linux-tegra-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 467 bytes --] On Mon, Oct 21, 2013 at 01:38:34PM +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org> > > Add the missing clk_disable_unprepare() before return > from gr2d_probe() in the error handling case. > > Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org> > --- > drivers/gpu/drm/tegra/gr2d.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. Thierry [-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-28 8:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-21 5:38 [PATCH -next] drm/tegra: add missing clk_disable_unprepare() on error in gr2d_probe() Wei Yongjun
[not found] ` <CAPgLHd_iff-PXrhOrVKi_qsqsBU7Yx0MByJDr_3_2fpJ8QwETQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-28 8:33 ` Terje Bergström
2013-10-28 8:54 ` Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox