From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org,
lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 2/3] hwmon: (lm90) add support to handle IRQ
Date: Wed, 30 Oct 2013 16:53:15 +0100 [thread overview]
Message-ID: <20131030165315.077703b3@endymion.delvare> (raw)
In-Reply-To: <1375856306-14415-3-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On Wed, 7 Aug 2013 14:18:25 +0800, Wei Ni wrote:
> When the temperature exceed the limit range value,
> the driver can handle the interrupt.
>
> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/hwmon/lm90.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> (...)
This one looks good now, thanks, with just one minor change I'd do
before committing:
> + dev_err(dev, "cannot request IRQ: %d\n", client->irq);
The ":" isn't really needed, I'll remove it.
--
Jean Delvare
next prev parent reply other threads:[~2013-10-30 15:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 6:18 [PATCH v4 0/3] Lm90 Enhancements Wei Ni
2013-08-07 6:18 ` [PATCH v4 1/3] hwmon: (lm90) Define status bits Wei Ni
[not found] ` <1375856306-14415-2-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-30 15:41 ` Jean Delvare
2013-10-30 17:03 ` Guenter Roeck
2013-10-31 2:47 ` Wei Ni
[not found] ` <5271C4C4.2040308-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-31 3:09 ` Wei Ni
[not found] ` <1375856306-14415-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-07 6:18 ` [PATCH v4 2/3] hwmon: (lm90) add support to handle IRQ Wei Ni
[not found] ` <1375856306-14415-3-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-30 15:53 ` Jean Delvare [this message]
2013-11-04 9:34 ` Jean Delvare
[not found] ` <20131104103434.5a085e27-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-11-04 10:05 ` Wei Ni
2013-09-09 6:16 ` [PATCH v4 0/3] Lm90 Enhancements Wei Ni
[not found] ` <522D67B2.4030406-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-09 7:42 ` Jean Delvare
2013-08-07 6:18 ` [PATCH v4 3/3] hwmon: (lm90) use enums for the indexes of temp8 and temp11 Wei Ni
[not found] ` <1375856306-14415-4-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-30 16:21 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030165315.077703b3@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox