DRM_TEGRA not buildable as a module

DRM_TEGRA not buildable as a module

[Josh Boyer]

Hi All,

The commit below seems to have made the Tegra DRM driver a bool option
instead of tristate:

commit dee8268f8fb218c9e9b604a40f7dbdd395e910f9
Author: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Date:   Wed Oct 9 10:32:49 2013 +0200

    drm/tegra: Move driver to DRM tree

    In order to make subsystem-wide changes easier, move the Tegra DRM
    driver back into the DRM tree.

    Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

That means you can't build the driver as a module.  Was this intended?
 The changelog doesn't mention anything about that and the existing
help text on the option seems to imply it should be buildable as a
module.

josh

Re: DRM_TEGRA not buildable as a module

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]

On Sat, Nov 16, 2013 at 03:25:09PM +0100, Josh Boyer wrote:
> Hi All,
> 
> The commit below seems to have made the Tegra DRM driver a bool option
> instead of tristate:
> 
> commit dee8268f8fb218c9e9b604a40f7dbdd395e910f9
> Author: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Date:   Wed Oct 9 10:32:49 2013 +0200
> 
>     drm/tegra: Move driver to DRM tree
> 
>     In order to make subsystem-wide changes easier, move the Tegra DRM
>     driver back into the DRM tree.
> 
>     Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> That means you can't build the driver as a module.  Was this intended?
>  The changelog doesn't mention anything about that and the existing
> help text on the option seems to imply it should be buildable as a
> module.

This was intended yes. And it wasn't really a change at all, since prior
to the commit you mention above the DRM driver was always built into the
host1x driver. That's why I didn't think it necessary to mention it in
the commit message.

I have some patches queued for 3.14 to enable the driver to be built as
a module. There are some dependencies such as symbols that need to be
exported so that the modules can be linked, so it'll require some amount
of coordination to make that work out within one release cycle, but I'm
hopeful that we can do it.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: DRM_TEGRA not buildable as a module

[Josh Boyer]

On Mon, Nov 18, 2013 at 4:10 AM, Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
> On Sat, Nov 16, 2013 at 03:25:09PM +0100, Josh Boyer wrote:
>> Hi All,
>>
>> The commit below seems to have made the Tegra DRM driver a bool option
>> instead of tristate:
>>
>> commit dee8268f8fb218c9e9b604a40f7dbdd395e910f9
>> Author: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> Date:   Wed Oct 9 10:32:49 2013 +0200
>>
>>     drm/tegra: Move driver to DRM tree
>>
>>     In order to make subsystem-wide changes easier, move the Tegra DRM
>>     driver back into the DRM tree.
>>
>>     Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>
>> That means you can't build the driver as a module.  Was this intended?
>>  The changelog doesn't mention anything about that and the existing
>> help text on the option seems to imply it should be buildable as a
>> module.
>
> This was intended yes. And it wasn't really a change at all, since prior
> to the commit you mention above the DRM driver was always built into the
> host1x driver. That's why I didn't think it necessary to mention it in
> the commit message.
>
> I have some patches queued for 3.14 to enable the driver to be built as
> a module. There are some dependencies such as symbols that need to be
> exported so that the modules can be linked, so it'll require some amount
> of coordination to make that work out within one release cycle, but I'm
> hopeful that we can do it.

OK.  Thanks for the detailed reply.

josh