From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/3] mfd: tps6586x: add version detection Date: Wed, 27 Nov 2013 15:30:19 +0000 Message-ID: <20131127153019.GR3296@lee--X1> References: <20131127130954.GF3296@lee--X1> <20131127135547.GK3296@lee--X1> <20131127143429.GN3296@lee--X1> <20131127143641.GO3296@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Stefan Agner Cc: swarren@wwwdotorg.org, thierry.reding@gmail.com, sameo@linux.intel.com, dev@lynxeye.de, mark.rutland@arm.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-tegra@vger.kernel.org On Wed, 27 Nov 2013, Stefan Agner wrote: > Am 2013-11-27 15:36, schrieb Lee Jones: > > >> Perhaps I should suggest to make TPS6586X_ANY a positive number th= en, > >> as a negative value to me indicates more of an error than a generi= c > >> parameter. > I see, its especially confusing since the version is filled using the > i2c_smbus_read_byte_data functions return value. The version field is= a > 8-Bit value according to the data sheet, I could use 0x100 as > TPS6586X_ANY identifier. How far are we away from using 0xFF? I'd be happy to use that and change it _if_ we ever get close. If it's likely that it'll be used, then sure 0x100 sounds okay too. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog