linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
Cc: swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
	dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org,
	lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	kai.poggensee-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org,
	sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 2/3] regulator: tps6586x: add and use correct voltage table
Date: Wed, 4 Dec 2013 10:48:10 +0100	[thread overview]
Message-ID: <20131204094809.GR19943@ulmo.nvidia.com> (raw)
In-Reply-To: <127fe07e18665f93aa8d7c03e03164f1a049ddb6.1386108712.git.stefan-XLVq0VzYD2Y@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

On Tue, Dec 03, 2013 at 11:18:47PM +0100, Stefan Agner wrote:
[...]
> diff --git a/drivers/regulator/tps6586x-regulator.c b/drivers/regulator/tps6586x-regulator.c
[...]
> +	/* Search version specific table first */
> +	if (table) {
> +		for (i = 0; i < num; i++) {
> +			ri = &table[i];
> +			if (ri->desc.id == id)
> +				return ri;
> +		}
> +	}

Ah... there you go. Looks good:

Reviewed-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2013-12-04  9:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03 22:18 [PATCH v4 0/3] regulator: tps6586x: add version detection and voltage tables Stefan Agner
2013-12-03 22:18 ` [PATCH v4 1/3] mfd: tps6586x: add version detection Stefan Agner
     [not found]   ` <77384d24810d9a22fc04cad6f7468f54a9cbaafe.1386108712.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-12-04  8:10     ` Lee Jones
2013-12-04  8:40       ` Stefan Agner
     [not found]         ` <e2ae7b9602d0c1e11f8e56ced17e9da0-XLVq0VzYD2Y@public.gmane.org>
2013-12-04 10:07           ` Lee Jones
2013-12-04 11:38             ` Stefan Agner
2013-12-04 11:48               ` Lee Jones
2013-12-04 11:49             ` Mark Brown
     [not found]               ` <20131204114909.GK29268-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-12-04 11:58                 ` Lee Jones
2013-12-05 17:06     ` Stephen Warren
2013-12-05 17:43       ` Stefan Agner
2013-12-05 17:40         ` Stephen Warren
     [not found]           ` <52A0BA85.4020201-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-05 22:56             ` Stefan Agner
     [not found]               ` <ac11b85d05765b3b68eff8c27041e965-XLVq0VzYD2Y@public.gmane.org>
2013-12-06  8:44                 ` Lee Jones
     [not found] ` <cover.1386108712.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-12-03 22:18   ` [PATCH v4 2/3] regulator: tps6586x: add and use correct voltage table Stefan Agner
     [not found]     ` <127fe07e18665f93aa8d7c03e03164f1a049ddb6.1386108712.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-12-04  9:48       ` Thierry Reding [this message]
2013-12-04 12:14       ` Mark Brown
2013-12-04 14:17         ` Stefan Agner
     [not found]           ` <0983a0fa016faa5674834afad4472413-XLVq0VzYD2Y@public.gmane.org>
2013-12-04 14:29             ` Mark Brown
     [not found]               ` <20131204142954.GW29268-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-12-04 14:40                 ` Lee Jones
2013-12-05 17:10       ` Stephen Warren
2013-12-03 22:18   ` [PATCH v4 3/3] ARM: tegra: correct Colibri T20 regulator settings Stefan Agner
     [not found]     ` <fc7440a2f4bf9ab95e47a911c0e0b3b6a2250356.1386108712.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-12-04 11:52       ` Lucas Stach
2013-12-05 17:12       ` Stephen Warren
2013-12-05 17:33         ` Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131204094809.GR19943@ulmo.nvidia.com \
    --to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org \
    --cc=kai.poggensee-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
    --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=stefan-XLVq0VzYD2Y@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).