Re: [PATCH V4] cpufreq: suspend governors on system suspend/hibernate

Borislav Petkov
2013-12-08T12:41:08Z

On Sun, Dec 08, 2013 at 01:34:36AM +0100, Rafael J. Wysocki wrote:
> On Saturday, December 07, 2013 04:24:09 PM Paul Bolle wrote:
> > On Sat, 2013-12-07 at 12:01 +0100, Bjørn Mork wrote:
> > > Sorry to be making noise here again, but I was eager to verify that the
> > > fixes in v3.13-rc3 were OK on my system. Unfortunately it seems this
> > > patch completely broke suspend for me. Hibernete ended up with a blank
> > > console and no visible activity, without ever writing any image to disk.
> > >
> > > There really weren't that many suspects between v3.13-rc2 and v3.13-rc3,
> > > so I went directly to reverting 5a87182aa21d ("cpufreq: suspend
> > > governors on system suspend/hibernate") which fixed the problem. I
> > > didn't bother debugging it further from there. I don't think there is
> > > anything magic about my system which should make this problem specific
> > > to it.
> > >
> > > I am still using the acpi-cpufreq driver on an old x86_64 laptop if that
> > > matters.
> >
> > On an x86 (32 bits) laptop hibernate also broke in v3.13-rc3. On that
> > machine hibernation itself worked, or at least seemed to work, but the
> > machine would basically stop after thawing (directly after loading the
> > hibernation image).
> >
> > And reverting commit 5a87182aa21d ("cpufreq: suspend governors on system
> > suspend/hibernate"), on top of v3.13-rc3, also lead to a successful
> > hibernation/thaw cycle.
>
> OK, reverted.

+1.

Grrr, I just wasted a whole morning bisecting the same issue as reported
above and can confirm the revert is the right thing to do.

Well, almost: the box almost suspends until I hear the clicking sound of
the mainboard trying to turn stuff off but then the fan remains on. When
I hit a button on the keyboard, it then turns off completely. This is
probably some nasty BIOS SMI crap which we don't have control over and
I'd guess unrelated to the issue at hand.

Anyway, Rafael, I was wondering: I have a couple of boxes here and it
would probably make a good sense to help out with testing this stuff
more - I just can't have suspend breakages.

Maybe you'd like me to give a run of your tree now and then to check
whether someone has sent you a quickly rushed brownpaper bag of
questionable nature and we can fish it out before it hits Linus. :)

So let me know.

Thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--