From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] ARM: tegra: Add Tegra124 PWM support
Date: Sat, 14 Dec 2013 13:26:28 +0100 [thread overview]
Message-ID: <20131214122628.GC17467@mithrandir> (raw)
In-Reply-To: <52AA143C.8010508-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 990 bytes --]
On Thu, Dec 12, 2013 at 12:53:32PM -0700, Stephen Warren wrote:
> On 11/18/2013 09:00 AM, Thierry Reding wrote:
> > The PWM controller on Tegra124 is the same as the one on earlier SoC
> > generations.
>
> I've applied this series to Tegra's for-3.14/dt branch. Given the recent
> conversion to the common reset framework and DT bindings, I needed to
> insert a couple extra lines in this patch:
>
> > diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
>
> > + pwm@7000a000 {
> > + compatible = "nvidia,tegra124-pwm", "nvidia,tegra20-pwm";
> > + reg = <0x7000a000 0x100>;
> > + #pwm-cells = <2>;
> > + clocks = <&tegra_car TEGRA124_CLK_PWM>;
>
> Here, I inserted:
>
> + resets = <&tegra_car 17>;
> + reset-names = "pwm";
>
> ... which matches the same node in at least tegra114.dtsi.
Looks good. I've also successfully tested this using next-20131213 with
working backlight on Venice2.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-12-14 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 16:00 [PATCH 1/2] ARM: tegra: Add Tegra124 PWM support Thierry Reding
[not found] ` <1384790435-30269-1-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-18 16:00 ` [PATCH 2/2] ARM: tegra: Enable PWM on Venice2 Thierry Reding
2013-12-12 19:53 ` [PATCH 1/2] ARM: tegra: Add Tegra124 PWM support Stephen Warren
[not found] ` <52AA143C.8010508-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-14 12:26 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131214122628.GC17467@mithrandir \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox