[PATCH 1/2] ARM: tegra: Add Tegra124 PWM support

[PATCH 1/2] ARM: tegra: Add Tegra124 PWM support

[Thierry Reding]

The PWM controller on Tegra124 is the same as the one on earlier SoC
generations.

Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 arch/arm/boot/dts/tegra124.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
index dcbf40b742fe..1e5fd14ecfad 100644
--- a/arch/arm/boot/dts/tegra124.dtsi
+++ b/arch/arm/boot/dts/tegra124.dtsi
@@ -114,6 +114,14 @@
 		status = "disabled";
 	};
 
+	pwm@7000a000 {
+		compatible = "nvidia,tegra124-pwm", "nvidia,tegra20-pwm";
+		reg = <0x7000a000 0x100>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car TEGRA124_CLK_PWM>;
+		status = "disabled";
+	};
+
 	rtc@7000e000 {
 		compatible = "nvidia,tegra124-rtc", "nvidia,tegra20-rtc";
 		reg = <0x7000e000 0x100>;
-- 
1.8.4.2

[PATCH 2/2] ARM: tegra: Enable PWM on Venice2

[Thierry Reding]

Subsequent patches will need to reference a PWM channel for backlight
support, so enable the PWM device and assign a label to it.

Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 arch/arm/boot/dts/tegra124-venice2.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/tegra124-venice2.dts b/arch/arm/boot/dts/tegra124-venice2.dts
index bc502112eb04..302f47704834 100644
--- a/arch/arm/boot/dts/tegra124-venice2.dts
+++ b/arch/arm/boot/dts/tegra124-venice2.dts
@@ -14,6 +14,10 @@
 		status = "okay";
 	};
 
+	pwm: pwm@7000a000 {
+		status = "okay";
+	};
+
 	pmc@7000e400 {
 		nvidia,invert-interrupt;
 		nvidia,suspend-mode = <1>;
-- 
1.8.4.2

Re: [PATCH 1/2] ARM: tegra: Add Tegra124 PWM support

[Stephen Warren]

On 11/18/2013 09:00 AM, Thierry Reding wrote:
> The PWM controller on Tegra124 is the same as the one on earlier SoC
> generations.

I've applied this series to Tegra's for-3.14/dt branch. Given the recent
conversion to the common reset framework and DT bindings, I needed to
insert a couple extra lines in this patch:

> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi

> +	pwm@7000a000 {
> +		compatible = "nvidia,tegra124-pwm", "nvidia,tegra20-pwm";
> +		reg = <0x7000a000 0x100>;
> +		#pwm-cells = <2>;
> +		clocks = <&tegra_car TEGRA124_CLK_PWM>;

Here, I inserted:

+               resets = <&tegra_car 17>;
+               reset-names = "pwm";

... which matches the same node in at least tegra114.dtsi.

> +		status = "disabled";
> +	};

Re: [PATCH 1/2] ARM: tegra: Add Tegra124 PWM support

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

On Thu, Dec 12, 2013 at 12:53:32PM -0700, Stephen Warren wrote:
> On 11/18/2013 09:00 AM, Thierry Reding wrote:
> > The PWM controller on Tegra124 is the same as the one on earlier SoC
> > generations.
> 
> I've applied this series to Tegra's for-3.14/dt branch. Given the recent
> conversion to the common reset framework and DT bindings, I needed to
> insert a couple extra lines in this patch:
> 
> > diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> 
> > +	pwm@7000a000 {
> > +		compatible = "nvidia,tegra124-pwm", "nvidia,tegra20-pwm";
> > +		reg = <0x7000a000 0x100>;
> > +		#pwm-cells = <2>;
> > +		clocks = <&tegra_car TEGRA124_CLK_PWM>;
> 
> Here, I inserted:
> 
> +               resets = <&tegra_car 17>;
> +               reset-names = "pwm";
> 
> ... which matches the same node in at least tegra114.dtsi.

Looks good. I've also successfully tested this using next-20131213 with
working backlight on Venice2.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]