From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heikki Krogerus Subject: Re: [PATCH] serial: 8250: enable UART_BUG_NOMSR for Tegra Date: Wed, 15 Jan 2014 13:12:05 +0200 Message-ID: <20140115111205.GA11732@xps8300> References: <1389132012-2257-1-git-send-email-swarren@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1389132012-2257-1-git-send-email-swarren@wwwdotorg.org> Sender: stable-owner@vger.kernel.org To: Stephen Warren Cc: Greg Kroah-Hartman , linux-serial@vger.kernel.org, linux-tegra@vger.kernel.org, olof@lixom.net, Stephen Warren , stable@vger.kernel.org List-Id: linux-tegra@vger.kernel.org Hi, On Tue, Jan 07, 2014 at 03:00:12PM -0700, Stephen Warren wrote: > diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c > index e33d38cb170f..61ecd709a722 100644 > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -2670,6 +2670,10 @@ static void serial8250_config_port(struct uart_port *port, int flags) > if (port->type == PORT_16550A && port->iotype == UPIO_AU) > up->bugs |= UART_BUG_NOMSR; > > + /* HW bugs may trigger IRQ while IIR == NO_INT */ > + if (port->type == PORT_TEGRA) > + up->bugs |= UART_BUG_NOMSR; > + Is there any reason this needs to be in 8250_core.c? Why not set it in drivers/tty/serial/of_serial.c? -- heikki