linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	Jani Nikula <jani.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>,
	Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
	intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 5/5] drm/tegra: Add eDP support
Date: Tue, 25 Feb 2014 09:00:17 +0100	[thread overview]
Message-ID: <20140225080016.GA4561@ulmo.nvidia.com> (raw)
In-Reply-To: <52E0349F.2050607-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

On Wed, Jan 22, 2014 at 02:14:07PM -0700, Stephen Warren wrote:
> On 01/21/2014 12:24 PM, Thierry Reding wrote:
[...]
> > +static void tegra_dpaux_write_fifo(struct tegra_dpaux *dpaux, const u8 *buffer,
> 
> Is that anything like writesl(); similar for
> tegra_dpaux_read_fifo()/readsl()?

I never got around to replying to this: the interface to the DPAUX FIFO
isn't a single register that uses non-incrementing writes, but rather a
set of five registers that map the entire FIFO linearly. So it can't be
written to with writesl() or read from with readsl().

The function names are slightly confusing in this regard. But the write
destination is still a FIFO, hence this choice of name.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

      parent reply	other threads:[~2014-02-25  8:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-21 19:24 [PATCH v4 0/5] drm/dp: Introduce AUX channel infrastructure Thierry Reding
2014-01-21 19:24 ` [PATCH v4 1/5] drm/dp: Add " Thierry Reding
     [not found]   ` <1390332263-11974-2-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-04  9:33     ` Jani Nikula
     [not found] ` <1390332263-11974-1-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-01-21 19:24   ` [PATCH v4 2/5] drm/dp: Add drm_dp_dpcd_read_link_status() Thierry Reding
2014-01-21 19:24   ` [PATCH v4 3/5] drm/dp: Add DisplayPort link helpers Thierry Reding
2014-01-21 19:24   ` [PATCH v4 4/5] drm/dp: Allow registering AUX channels as I2C busses Thierry Reding
2014-02-04  9:29     ` Jani Nikula
2014-01-21 19:24   ` [PATCH v4 5/5] drm/tegra: Add eDP support Thierry Reding
     [not found]     ` <1390332263-11974-6-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-01-22 21:14       ` Stephen Warren
     [not found]         ` <52E0349F.2050607-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-02-25  8:00           ` Thierry Reding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140225080016.GA4561@ulmo.nvidia.com \
    --to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
    --cc=daniel-/w4YWyX8dFk@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=jani.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).