Re: [PATCH 1/2] ARM: DT: fix gic interrupt controller documentation

Jason Gunthorpe
2014-03-13T18:25:54Z

On Thu, Mar 13, 2014 at 11:44:33AM -0600, Stephen Warren wrote:
> On 03/13/2014 11:40 AM, Tim Harvey wrote:
> > When using interrupt-maps, the size of a map entry is #address-cells +
> > #interrupt-cells for the parent interrupt controller. For the ARM GIC
> > address-cells should be 0 as this is not used.
> >
> > This patch fixes the example by correctly specifying #address-cells = 0.
>
> If the #address-cells property is required (well, or even optional...)
> in the node, shouldn't it be included in the list of required/optional
> properties above, and not solely included in the example?

AFAIK, #address-cells = 0 is the same as not including a
#address-cells at all.

Omitting entirely is what other interrupt-controller bindings are
doing, so I'd just drop mention of #address-cells completely.

Jason