From: Thierry Reding <thierry.reding@gmail.com>
To: "Terje Bergström" <tbergstrom@nvidia.com>
Cc: "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Stephen Warren <swarren@nvidia.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH] gpu: host1x: handle the correct # of syncpt regs
Date: Fri, 4 Apr 2014 11:03:25 +0200 [thread overview]
Message-ID: <20140404090324.GC474@ulmo> (raw)
In-Reply-To: <533D1732.9040704@nvidia.com>
[-- Attachment #1.1: Type: text/plain, Size: 1631 bytes --]
On Thu, Apr 03, 2014 at 11:09:22AM +0300, Terje Bergström wrote:
> On 01.04.2014 23:10, Stephen Warren wrote:
> > diff --git a/drivers/gpu/host1x/hw/intr_hw.c b/drivers/gpu/host1x/hw/intr_hw.c
> > index db9017adfe2b..17407b2de2bf 100644
> > --- a/drivers/gpu/host1x/hw/intr_hw.c
> > +++ b/drivers/gpu/host1x/hw/intr_hw.c
> > @@ -47,7 +47,7 @@ static irqreturn_t syncpt_thresh_isr(int irq, void *dev_id)
> > unsigned long reg;
> > int i, id;
> >
> > - for (i = 0; i <= BIT_WORD(host->info->nb_pts); i++) {
> > + for (i = 0; i < BITS_TO_LONGS(host->info->nb_pts); i++) {
> > reg = host1x_sync_readl(host,
> > HOST1X_SYNC_SYNCPT_THRESH_CPU0_INT_STATUS(i));
> > for_each_set_bit(id, ®, BITS_PER_LONG) {
> > @@ -64,7 +64,7 @@ static void _host1x_intr_disable_all_syncpt_intrs(struct host1x *host)
> > {
> > u32 i;
> >
> > - for (i = 0; i <= BIT_WORD(host->info->nb_pts); ++i) {
> > + for (i = 0; i < BITS_TO_LONGS(host->info->nb_pts); ++i) {
> > host1x_sync_writel(host, 0xffffffffu,
> > HOST1X_SYNC_SYNCPT_THRESH_INT_DISABLE(i));
> > host1x_sync_writel(host, 0xffffffffu,
> >
>
> Wouldn't this break in architectures with 64-bit longs?
Well, BIT_WORD() relies on BITS_PER_LONG too, so the current code is
broken for 64-bit architectures too.
> Probably the safest way would be to use DIV_ROUND_UP(host->info->nb_pts, 32),
> because we know there are 32 bits in each host1x register.
I agree. I hope there aren't any plans on making the registers 64 bits
wide in the future. Although they'd probably still be accessible as 32
bit values even then.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2014-04-04 9:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 20:10 [PATCH] gpu: host1x: handle the correct # of syncpt regs Stephen Warren
2014-04-03 8:09 ` Terje Bergström
2014-04-04 9:03 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404090324.GC474@ulmo \
--to=thierry.reding@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=tbergstrom@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox