From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 3/7] mfd: cros_ec: spi: Make the cros_ec_spi timeout more reliable Date: Wed, 23 Apr 2014 13:35:10 +0100 Message-ID: <20140423123510.GD640@lee--X1> References: <1398185154-19404-1-git-send-email-dianders@chromium.org> <1398185154-19404-4-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1398185154-19404-4-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Anderson Cc: swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Tue, 22 Apr 2014, Doug Anderson wrote: > The cros_ec_spi transfer had two problems with its timeout code: >=20 > 1. It looked at the timeout even in the case that it found valid data= =2E > 2. If the cros_ec_spi code got switched out for a while, it's possibl= e > it could get a timeout after a single loop. Let's be paranoid and > make sure we do one last transfer after the timeout expires. >=20 > Signed-off-by: Doug Anderson > Reviewed-by: Simon Glass > Tested-by: Andrew Bresticker > Tested-by: Stephen Warren > --- > Changes in v2: None >=20 > drivers/mfd/cros_ec_spi.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) Waiting for other subsystems to Ack, so for now: Acked-by: Lee Jones --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog